Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use cmd /c npm.cmd instead of just npm.cmd on windows #15

Merged
merged 4 commits into from
Aug 1, 2020
Merged

use cmd /c npm.cmd instead of just npm.cmd on windows #15

merged 4 commits into from
Aug 1, 2020

Conversation

kilork
Copy link
Owner

@kilork kilork commented Jul 30, 2020

fixes #14

@kilork
Copy link
Owner Author

kilork commented Jul 30, 2020

Need a windows box to check, looks like we need to add appveyor in the future.

idursun
idursun reviewed Jul 31, 2020
View reviewed changes
src/impl.rs Outdated Show resolved Hide resolved
@kilork kilork merged commit 19eb032 into master Aug 1, 2020
@kilork kilork deleted the 14_npm_windows branch August 1, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idursun idursun idursun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoking npm.cmd on Windows is failing
2 participants
@kilork @idursun