Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-upgrade and single item tables #713

Closed
wants to merge 1 commit into from

Conversation

Tosainu
Copy link

@Tosainu Tosainu commented Jun 26, 2022

cargo upgrade collapses a table if it has only one item and produces the line without a space after the crate name.

[dependencies]
inline_table = { version = "0.1.0" }
string = "0.1.0"

[dependencies.table]
version = "0.1.0"
[dependencies]
inline_table = "0.1.0"
string = "0.1.0"
table= "0.1.0"

This PR changes to preserve a single item table to avoid this problem.

Fixes #717

@epage
Copy link
Collaborator

epage commented Jun 28, 2022

Could you open an issue for this? I'd like to discuss the problem statement and how we plan to solve that and prefer that to be in issues and leaving PRs for the implementation. For example, sometimes there ends up being multiple PR attempts for the same issue and having the common info all in one place is helpful

@Tosainu
Copy link
Author

Tosainu commented Jul 2, 2022

➡️ #717

@epage
Copy link
Collaborator

epage commented Jul 13, 2022

Superseded by #725

@epage epage closed this Jul 13, 2022
@Tosainu Tosainu deleted the preserve-1-len-table branch July 15, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-upgrade and single item tables
2 participants