Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export TypedFetcherWithComponents type #17

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

joelazar
Copy link
Contributor

@joelazar joelazar commented Nov 7, 2022

Exporting the TypedFetcherWithComponents comes handy, when you would like to pass around a fetcher in react components and you would like to type those components.

Also, it's exported in the remix-react base package as well.

@kiliman kiliman merged commit 61baf88 into kiliman:main Nov 7, 2022
@kiliman
Copy link
Owner

kiliman commented Nov 7, 2022

Thanks for the PR!

@lukebowerman
Copy link
Contributor

lukebowerman commented Nov 8, 2022

Hi! This PR actually solves a problem I ran into this morning but when I pulled in 0.1.5 of the package I'm not seeing the TypedFetcherWithComponents in the resulting dist/index.d.ts file. Is is possible that the deploy didn't actually reflect this change?

Contents of index.d.ts from NPM package v0.1.5:

export { deserializeRemix, redirect, stringifyRemix, typedjson, useTypedActionData, useTypedFetcher, useTypedLoaderData, } from './remix';
export type { TypedJsonResponse, TypedMetaFunction } from './remix';
export { applyMeta, deserialize, parse, serialize, stringify, } from './typedjson';
export type { MetaType, TypedJsonResult } from './typedjson';

@kiliman
Copy link
Owner

kiliman commented Nov 8, 2022

Sorry. Not sure what happened. Anyway, I rebuilt and repubilshed as v0.1.6.

@lukebowerman
Copy link
Contributor

@kiliman - No worries! Thank you for the quick fix and really appreciate the package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants