Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(execa): use await execa instead of execaSync since it produces unexpected errors when spawning git commands - fixes #17 #25

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix(execa): use await execa instead of execaSync since it produces unexpected errors when spawning git commands - fixes #17 #25

merged 2 commits into from
Oct 24, 2024

Conversation

kilianpaquier
Copy link
Owner

@kilianpaquier kilianpaquier commented Oct 24, 2024 •
edited
Loading

Fixes both #17 and #20

@kilianpaquier kilianpaquier self-assigned this Oct 24, 2024
@github-actions github-actions bot added bug Something isn't working test Pull requests that add testcases typescript labels Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.08451% with 51 lines in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (29c7f75) to head (3330d70).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/git.ts 29.26% 29 Missing ⚠️
lib/pull-request.ts 8.33% 22 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   91.40%   90.09%   -1.31%     
==========================================
  Files          12       12              
  Lines         989     1030      +41     
==========================================
+ Hits          904      928      +24     
- Misses         85      102      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kilianpaquier kilianpaquier added the javascript Pull requests that update Javascript code label Oct 24, 2024
@kilianpaquier kilianpaquier force-pushed the fix/kpaquier/exexa-sync branch 2 times, most recently from b150547 to 212ae4f Compare October 24, 2024 09:20
@kilianpaquier kilianpaquier linked an issue Oct 24, 2024 that may be closed by this pull request
Failed to backmerge branches.: xJ: Command failed with ENOENT: git fetch #17
Closed
@kilianpaquier kilianpaquier changed the title fix(execa): use await execa instead of execaSync since it produces unexpected errors when spawning git commands - fixes #19 fix(execa): use await execa instead of execaSync since it produces unexpected errors when spawning git commands - fixes #17 Oct 24, 2024
@kilianpaquier
Copy link
Owner Author

Hi @syphernl, is it OK on your end with this code ? I'm gonna add the debug logs in another commit.

@kilianpaquier
Copy link
Owner Author

Uses most of produced code from here #24

@kilianpaquier
fix(execa): use await execa instead of execaSync since it produce…
f42bfef 
…s unexpected errors when spawning git commands - fixes #17

Co-authored-by: syphernl <syphernl@users.noreply.github.com>

Signed-off-by: kilianpaquier <kilian@kilianpaquier.com>
@kilianpaquier kilianpaquier force-pushed the fix/kpaquier/exexa-sync branch from 212ae4f to f42bfef Compare October 24, 2024 09:35
@syphernl
Copy link
Contributor

Hi @syphernl, is it OK on your end with this code ? I'm gonna add the debug logs in another commit.

Applied these changes on my test env, no git errors regarding ENOENT anymore so in that regard it seems to be working.
Still getting the "Updates were rejected because the tip of your current branch is behind" but that will be handled in #23

@kilianpaquier
Copy link
Owner Author

Great, I'm gonna add debug logs and check this tip issue afterhand but in another PR

@kilianpaquier kilianpaquier linked an issue Oct 24, 2024 that may be closed by this pull request
Possible issue with git merge (not up to date local changes) #23
Closed
@kilianpaquier kilianpaquier removed a link to an issue Oct 24, 2024
Possible issue with git merge (not up to date local changes) #23
Closed
@kilianpaquier kilianpaquier linked an issue Oct 24, 2024 that may be closed by this pull request
Implement debug logs #20
Closed
@kilianpaquier
feat: add multiple debug logs - fixes #20
3330d70 
Signed-off-by: kilianpaquier <kilian@kilianpaquier.com>
@kilianpaquier kilianpaquier force-pushed the fix/kpaquier/exexa-sync branch from 3545245 to 3330d70 Compare October 24, 2024 13:14
@kilianpaquier kilianpaquier merged commit 512cf18 into main Oct 24, 2024
8 of 9 checks passed
@kilianpaquier kilianpaquier deleted the fix/kpaquier/exexa-sync branch October 24, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version v1.4.0 🎉

@github-actions github-actions bot added the released Issue or pull request released main channel label Oct 24, 2024
@kilianpaquier kilianpaquier mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kilianpaquier kilianpaquier

Labels
bug Something isn't working javascript Pull requests that update Javascript code released Issue or pull request released main channel test Pull requests that add testcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement debug logs Failed to backmerge branches.: xJ: Command failed with ENOENT: git fetch
2 participants
@kilianpaquier @syphernl