Change the collection view changes to iOS 18 #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbmorgan
reviewed
Jan 24, 2025
| @@ -15,7 +15,7 @@ fi | |||
| rm -rf ${PWD}/build | |||
|
|
|||
| # Run KIF Tests | |||
| env NSUnbufferedIO=YES xcodebuild test -project KIF.xcodeproj -scheme KIF -derivedDataPath=${PWD}/build/KIF -destination "platform=iOS Simulator,${SIMULATOR}" | xcpretty -c | |||
| env NSUnbufferedIO=YES xcodebuild test -project KIF.xcodeproj -scheme KIF -derivedDataPath=${PWD}/build/KIF -destination "platform=iOS Simulator,${SIMULATOR}" CODE_SIGNING_ALLOWED=NO | xcbeautify | |||
There was a problem hiding this comment.
What's the reason for adding CODE_SIGNING_ALLOWED=NO here?
There was a problem hiding this comment.
Because it was failing to build with a you need a signing cert/company chosen.
Tim was trying to fix it here: #1320
There was a problem hiding this comment.
The error was:
Testing failed: Signing for "KIFTests" requires a development team. Select a development team in the Signing & Capabilities editor. Signing for "TestHost" requires a development team. Select a development team in the Signing & Capabilities editor. Testing cancelled because the build failed.
congt
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the new scrolling logic when on iOS 18+