Scroll once when waiting for UITableViewCells #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would call `UITableView.scrollToRow(at:at:animated:)` every runloop while we waited for the scroll to complete. This caused multiple unnecessary calls to the delegate's `scrollViewDidEndScrollingAnimation(_:)` method. This change resolves the issue by moving the call to scroll to the row outside of the `KIFTestActor.run(_:)` block.
|
I also noted that the implementation of the UICollectionView's wait for cell method differs in it's implementation such that it doesn't do the incremental waiting and just waits for 0.5seconds. Not sure if I should update one or the other to match. |
justinseanmartin
approved these changes
Mar 19, 2020
|
I'd recommend leaving the collection view as is for now unless there is something specific that it is breaking and we can determine that the change is safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would call
UITableView.scrollToRow(at:at:animated:)every runloop while we waited for the scroll to complete. This caused
multiple unnecessary calls to the delegate's
scrollViewDidEndScrollingAnimation(_:)method. This change resolvesthe issue by moving the call to scroll to the row outside of the
KIFTestActor.run(_:)block.