Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add Chung constants to kflib #659

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

r3m0chop
Copy link
Contributor

@r3m0chop r3m0chop commented Mar 9, 2023

New ingest constants as for the Chung FY20 WGS&RNA clinical data, thank you very much!

Please note that this branch builds upon the new Letra family relationships of PR #657 (and therefore includes those Letra commits, rather than a rebased PR; once the Letra branch has been merged into master, hoping that this PR only shows the outstanding Chung-specific commits)

cc: M1 team: @znatty22 , @chris-s-friedman , @youngnm , Meen, etc
cc: KF-DRC: @Christina-J-Diaz , @HigginsD3b, @aw3334

@r3m0chop r3m0chop requested a review from a team as a code owner March 9, 2023 14:08
@chris-s-friedman chris-s-friedman changed the title Add Chung constants to kflib ✨Add Chung constants to kflib Mar 9, 2023
@chris-s-friedman
Copy link
Contributor

@r3m0chop - I'm thinking that maybe we should convert this to a draft until #657 is merged since it depends on those changes.

@chris-s-friedman chris-s-friedman added the extract Relating to the extract stage label Mar 9, 2023
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to rebase on master and then it'll be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extract Relating to the extract stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants