Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔊 Rearrange target ID inquiry to improve load logging #603

Merged
merged 1 commit into from
May 10, 2021
Merged

🔊 Rearrange target ID inquiry to improve load logging #603

merged 1 commit into from
May 10, 2021

Conversation

fiendish
Copy link
Contributor

@fiendish fiendish commented May 10, 2021 •
edited
Loading

Adds a new log message at the end that looks like

2021-05-09 22:43:44,002 - LoadStage - Thread: MainThread - INFO - Load Summary:
{'biospecimen': {'ADD': 0, 'UPDATE': 5},
 'biospecimen_genomic_file': {'ADD': 10, 'UPDATE': 0},
 'genomic_file': {'ADD': 0, 'UPDATE': 10},
 'sequencing_experiment': {'ADD': 0, 'UPDATE': 5},
 'sequencing_experiment_genomic_file': {'ADD': 10, 'UPDATE': 0}}

etc

Using dry run with a --query_url set will give a summary report for the number of new vs existing entities.

@fiendish fiendish requested a review from a team as a code owner May 10, 2021 04:44
liberaliscomputing
liberaliscomputing approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@liberaliscomputing liberaliscomputing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fiendish fiendish merged commit 826b9ba into master May 10, 2021
@fiendish fiendish deleted the logsummaries branch May 10, 2021 19:18
fiendish added a commit that referenced this pull request May 13, 2021
@fiendish
🏷️ Release 1.6.0
b882d21 
## Release 1.6.0

### Summary

- Emojis: 🔧 x1, 🔊 x1
- Categories: Additions x1, Other Changes x1

### New features and changes

- [#602](#602) - 🔧 Fix Homo sapiens casing - [bec3565](bec3565) by [liberaliscomputing](https://github.com/liberaliscomputing)
- [#603](#603) - 🔊 Rearrange target ID inquiry to improve load logging - [826b9ba](826b9ba) by [fiendish](https://github.com/fiendish)
This was referenced May 13, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liberaliscomputing liberaliscomputing liberaliscomputing approved these changes

@znatty22 znatty22 Awaiting requested review from znatty22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiendish @liberaliscomputing