🐛 Family ID is optional for Participants #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicholasvk @chris-s-friedman , can y'all test that this change addresses your issue? |
fiendish
force-pushed
the
pfamily
branch
2 times, most recently
from
2feaf1e to
38c53cc
Compare
fiendish
requested review from
znatty22,
chris-s-friedman and
nicholasvk
and removed request for
znatty22
chris-s-friedman
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
tested it with @abgeorge7's ingest package that we're developing. @ https://github.com/kids-first/kf-ingest-packages/commit/9059023d530ca5519a9fb50762b5b39624342a41 we just ingest participant id only (no family id... or anything else). the ingest lib throws no errors :)
Ok but does it work? :) |
|
the ingest ran successfully into qa. in the qa dtaservice, family link is @youngnm does it look good in qa postgres? |
|
great |
Closed
fiendish
added a commit
that referenced
this pull request
Feb 6, 2021
## Release 1.0.0 ### New features and changes - [#570](#570) - 🔊🐛 More verbose loader logging + loader fixes - [ee06380](ee06380) by [znatty22](https://github.com/znatty22) - [#564](#564) - 🐛 Validate V1 API configurations - [41dfe3c](41dfe3c) by [fiendish](https://github.com/fiendish) - [#568](#568) - ♻️ Don't silently cross-assign SE.SL/SE.ID - [002b252](002b252) by [fiendish](https://github.com/fiendish) - [#523](#523) - 📝 Update documentation for recent changes - [f84e272](f84e272) by [fiendish](https://github.com/fiendish) - [#567](#567) - 🐛 Don't nullify coerced integers - [5439e4e](5439e4e) by [fiendish](https://github.com/fiendish) - [#566](#566) - 💬 Add FredHutch sequencing center - [fe49db9](fe49db9) by [fiendish](https://github.com/fiendish) - [#563](#563) - 🔥 Remove test files from template project - [0653622](0653622) by [fiendish](https://github.com/fiendish) - [#562](#562) - 🔧 Add marrow procurement to validator - [c7ccbd5](c7ccbd5) by [fiendish](https://github.com/fiendish) - [#561](#561) - 🔥 Remove dead css file from doc generation - [f1b24c6](f1b24c6) by [fiendish](https://github.com/fiendish) - [#555](#555) - ➖ Use a mutex instead of sqlite3worker - [d73961c](d73961c) by [fiendish](https://github.com/fiendish) - [#554](#554) - 🐛 Ensure integers fit into allocated bits - [b6ad332](b6ad332) by [fiendish](https://github.com/fiendish) - [#553](#553) - 💬 Add maf format to constants - [31266e8](31266e8) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#552](#552) - ✨ Add option to query from another source in Load - [04f0310](04f0310) by [fiendish](https://github.com/fiendish) - [#551](#551) - 💬 Add sickkids sequencing center - [e250fbb](e250fbb) by [youngnm](https://github.com/youngnm) - [#550](#550) - 💬 New constant for marrow aspiration - [f82589b](f82589b) by [fiendish](https://github.com/fiendish) - [#548](#548) - 🐛 Remove non-member fields before submitting - [0310c62](0310c62) by [fiendish](https://github.com/fiendish) - [#547](#547) - ✏️ Fix BC_CANCER_AGENCY typo - [dd3f227](dd3f227) by [fiendish](https://github.com/fiendish) - [#549](#549) - ✨ Convert family relations to P1+P2+rel - [f5ce3d2](f5ce3d2) by [fiendish](https://github.com/fiendish) - [#546](#546) - 💬 Add string constant for html type - [d201dfa](d201dfa) by [fiendish](https://github.com/fiendish) - [#541](#541) - 🐛 Reference participant/study in more service plugin key components - [fe5546f](fe5546f) by [fiendish](https://github.com/fiendish) - [#542](#542) - 💚 Fix sphinx theme install egg name - [0935579](0935579) by [fiendish](https://github.com/fiendish) - [#539](#539) - 📌 Make some of the dependencies flexible - [f519be3](f519be3) by [fiendish](https://github.com/fiendish) - [#537](#537) - 🔊 Add html validation report - [2fe259e](2fe259e) by [fiendish](https://github.com/fiendish) - [#536](#536) - 🐛 Escape strings before adding to markdown - [80be37f](80be37f) by [fiendish](https://github.com/fiendish) - [#532](#532) - ⬆️ Update dependencies for Python 3.9 - [3802a55](3802a55) by [fiendish](https://github.com/fiendish) - [#533](#533) - ✨ Add Ashion Sequencing center to constants.py - [a0d11b6](a0d11b6) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#531](#531) - 🐛 Fake-cache target IDs in dry run mode - [5352c24](5352c24) by [fiendish](https://github.com/fiendish) - [#529](#529) - 🐛 Fix bad call order blocking BS and SE loads - [2d14c3e](2d14c3e) by [fiendish](https://github.com/fiendish) - [#527](#527) - 🐛 Don't show blank cells as invalid values - [7eb86a4](7eb86a4) by [fiendish](https://github.com/fiendish) - [#522](#522) - 🐛 Don't contact server during dry run testing - [c802ab5](c802ab5) by [fiendish](https://github.com/fiendish) - [#524](#524) - 👽 Add auth configs for new study creator subdomains - [027b60c](027b60c) by [fiendish](https://github.com/fiendish) - [#514](#514) - 🐛 Correct study ID/TARGET_SERVICE_ID overwrite - [4ba24ae](4ba24ae) by [fiendish](https://github.com/fiendish) - [#513](#513) - ♻️ Break dependency on local ID cache - [b70f26f](b70f26f) by [fiendish](https://github.com/fiendish) - [#521](#521) - ✨ Add hmb-npu to constants.CONSENT_TYPE - [4151df8](4151df8) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#520](#520) - 🎨 Display test result summary as table - [d8346e8](d8346e8) by [znatty22](https://github.com/znatty22) - [#518](#518) - 📝 Consolidate example extract config copies - [a453461](a453461) by [fiendish](https://github.com/fiendish) - [#517](#517) - 📝 Import Split() in docs extract config - [a3ecfdd](a3ecfdd) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#495](#495) - 💬 Add concepts for participant template - [7c319f4](7c319f4) by [fiendish](https://github.com/fiendish) - [#499](#499) - ✨ Data Validation - [20ac772](20ac772) by [znatty22](https://github.com/znatty22) - [#509](#509) - 🐛 Detect encodings of files when reading - [263d1bf](263d1bf) by [fiendish](https://github.com/fiendish) - [#497](#497) - 🐛 Family ID is optional for Participants - [7944c6e](7944c6e) by [fiendish](https://github.com/fiendish) - [#487](#487) - 🐛 Remove bool json type cast - [794a387](794a387) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#492](#492) - 🔥 Remove old accounting code - [1ebcb1f](1ebcb1f) by [znatty22](https://github.com/znatty22) - [#482](#482) - 👷 Migrate to gh actions - [5b6d4a5](5b6d4a5) by [blackdenc](https://github.com/blackdenc) - [#484](#484) - ✨ Add sequencing centers - [6cc18b5](6cc18b5) by [liberaliscomputing](https://github.com/liberaliscomputing) - [#485](#485) - 💚 Unbreak tests on Circle - [f7ef977](f7ef977) by [fiendish](https://github.com/fiendish) - [#472](#472) - ⬆️ Upgrade click dependency - [69175af](69175af) by [fiendish](https://github.com/fiendish) - [#470](#470) - 📝 Add example target plugins to the tutorial - [7fd17eb](7fd17eb) by [fiendish](https://github.com/fiendish) - [#469](#469) - 👷 Automate tagging releases - [d05b4da](d05b4da) by [fiendish](https://github.com/fiendish)
Merged
fiendish
added a commit
that referenced
this pull request
Feb 6, 2021
## Release 1.0.0 ### Summary - Emojis: 🐛 x15, 🔊 x2, ♻️ x2, 📝 x4, 💬 x6, 🔥 x3, 🔧 x1, ➖ x1, ✨ x6, ✏️ x1, 💚 x2, 📌 x1, ⬆️ x2, 👽 x1, 🎨 x1, 👷 x2 - Categories: Additions x8, Documentation x4, Removals x4, Fixes x23, Ops x7, Other Changes x4 ### New features and changes - [#570](#570) - 🔊🐛 More verbose loader logging + loader fixes - [ee06380](ee06380) by [znatty22](https://github.com/znatty22) - [#564](#564) - 🐛 Validate V1 API configurations - [41dfe3c](41dfe3c) by [fiendish](https://github.com/fiendish) - [#568](#568) - ♻️ Don't silently cross-assign SE.SL/SE.ID - [002b252](002b252) by [fiendish](https://github.com/fiendish) - [#523](#523) - 📝 Update documentation for recent changes - [f84e272](f84e272) by [fiendish](https://github.com/fiendish) - [#567](#567) - 🐛 Don't nullify coerced integers - [5439e4e](5439e4e) by [fiendish](https://github.com/fiendish) - [#566](#566) - 💬 Add FredHutch sequencing center - [fe49db9](fe49db9) by [fiendish](https://github.com/fiendish) - [#563](#563) - 🔥 Remove test files from template project - [0653622](0653622) by [fiendish](https://github.com/fiendish) - [#562](#562) - 🔧 Add marrow procurement to validator - [c7ccbd5](c7ccbd5) by [fiendish](https://github.com/fiendish) - [#561](#561) - 🔥 Remove dead css file from doc generation - [f1b24c6](f1b24c6) by [fiendish](https://github.com/fiendish) - [#555](#555) - ➖ Use a mutex instead of sqlite3worker - [d73961c](d73961c) by [fiendish](https://github.com/fiendish) - [#554](#554) - 🐛 Ensure integers fit into allocated bits - [b6ad332](b6ad332) by [fiendish](https://github.com/fiendish) - [#553](#553) - 💬 Add maf format to constants - [31266e8](31266e8) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#552](#552) - ✨ Add option to query from another source in Load - [04f0310](04f0310) by [fiendish](https://github.com/fiendish) - [#551](#551) - 💬 Add sickkids sequencing center - [e250fbb](e250fbb) by [youngnm](https://github.com/youngnm) - [#550](#550) - 💬 New constant for marrow aspiration - [f82589b](f82589b) by [fiendish](https://github.com/fiendish) - [#548](#548) - 🐛 Remove non-member fields before submitting - [0310c62](0310c62) by [fiendish](https://github.com/fiendish) - [#547](#547) - ✏️ Fix BC_CANCER_AGENCY typo - [dd3f227](dd3f227) by [fiendish](https://github.com/fiendish) - [#549](#549) - ✨ Convert family relations to P1+P2+rel - [f5ce3d2](f5ce3d2) by [fiendish](https://github.com/fiendish) - [#546](#546) - 💬 Add string constant for html type - [d201dfa](d201dfa) by [fiendish](https://github.com/fiendish) - [#541](#541) - 🐛 Reference participant/study in more service plugin key components - [fe5546f](fe5546f) by [fiendish](https://github.com/fiendish) - [#542](#542) - 💚 Fix sphinx theme install egg name - [0935579](0935579) by [fiendish](https://github.com/fiendish) - [#539](#539) - 📌 Make some of the dependencies flexible - [f519be3](f519be3) by [fiendish](https://github.com/fiendish) - [#537](#537) - 🔊 Add html validation report - [2fe259e](2fe259e) by [fiendish](https://github.com/fiendish) - [#536](#536) - 🐛 Escape strings before adding to markdown - [80be37f](80be37f) by [fiendish](https://github.com/fiendish) - [#532](#532) - ⬆️ Update dependencies for Python 3.9 - [3802a55](3802a55) by [fiendish](https://github.com/fiendish) - [#533](#533) - ✨ Add Ashion Sequencing center to constants.py - [a0d11b6](a0d11b6) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#531](#531) - 🐛 Fake-cache target IDs in dry run mode - [5352c24](5352c24) by [fiendish](https://github.com/fiendish) - [#529](#529) - 🐛 Fix bad call order blocking BS and SE loads - [2d14c3e](2d14c3e) by [fiendish](https://github.com/fiendish) - [#527](#527) - 🐛 Don't show blank cells as invalid values - [7eb86a4](7eb86a4) by [fiendish](https://github.com/fiendish) - [#522](#522) - 🐛 Don't contact server during dry run testing - [c802ab5](c802ab5) by [fiendish](https://github.com/fiendish) - [#524](#524) - 👽 Add auth configs for new study creator subdomains - [027b60c](027b60c) by [fiendish](https://github.com/fiendish) - [#514](#514) - 🐛 Correct study ID/TARGET_SERVICE_ID overwrite - [4ba24ae](4ba24ae) by [fiendish](https://github.com/fiendish) - [#513](#513) - ♻️ Break dependency on local ID cache - [b70f26f](b70f26f) by [fiendish](https://github.com/fiendish) - [#521](#521) - ✨ Add hmb-npu to constants.CONSENT_TYPE - [4151df8](4151df8) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#520](#520) - 🎨 Display test result summary as table - [d8346e8](d8346e8) by [znatty22](https://github.com/znatty22) - [#518](#518) - 📝 Consolidate example extract config copies - [a453461](a453461) by [fiendish](https://github.com/fiendish) - [#517](#517) - 📝 Import Split() in docs extract config - [a3ecfdd](a3ecfdd) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#495](#495) - 💬 Add concepts for participant template - [7c319f4](7c319f4) by [fiendish](https://github.com/fiendish) - [#499](#499) - ✨ Data Validation - [20ac772](20ac772) by [znatty22](https://github.com/znatty22) - [#509](#509) - 🐛 Detect encodings of files when reading - [263d1bf](263d1bf) by [fiendish](https://github.com/fiendish) - [#497](#497) - 🐛 Family ID is optional for Participants - [7944c6e](7944c6e) by [fiendish](https://github.com/fiendish) - [#487](#487) - 🐛 Remove bool json type cast - [794a387](794a387) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#492](#492) - 🔥 Remove old accounting code - [1ebcb1f](1ebcb1f) by [znatty22](https://github.com/znatty22) - [#482](#482) - 👷 Migrate to gh actions - [5b6d4a5](5b6d4a5) by [blackdenc](https://github.com/blackdenc) - [#484](#484) - ✨ Add sequencing centers - [6cc18b5](6cc18b5) by [liberaliscomputing](https://github.com/liberaliscomputing) - [#485](#485) - 💚 Unbreak tests on Circle - [f7ef977](f7ef977) by [fiendish](https://github.com/fiendish) - [#472](#472) - ⬆️ Upgrade click dependency - [69175af](69175af) by [fiendish](https://github.com/fiendish) - [#470](#470) - 📝 Add example target plugins to the tutorial - [7fd17eb](7fd17eb) by [fiendish](https://github.com/fiendish) - [#469](#469) - 👷 Automate tagging releases - [d05b4da](d05b4da) by [fiendish](https://github.com/fiendish)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #488