Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix query sample relationships #674

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

znatty22
Copy link
Member

Querying for sample-relationships by a sample_id would fail if the results contained any relationships where the parent/child is null. We forgot to account for this in developing the sample-relationships API

@znatty22 znatty22 added the bug Something isn't working label Jun 13, 2024
@znatty22 znatty22 self-assigned this Jun 13, 2024
@znatty22 znatty22 requested a review from calkinsh June 13, 2024 15:06
@znatty22 znatty22 marked this pull request as ready for review June 13, 2024 15:07
@znatty22 znatty22 requested a review from a team as a code owner June 13, 2024 15:07
@znatty22 znatty22 merged commit 8d261b6 into master Jun 13, 2024
5 checks passed
@znatty22 znatty22 deleted the fix-query-sample-relationships branch June 13, 2024 15:29
znatty22 added a commit that referenced this pull request Jun 13, 2024
## Release 1.31.0

### Summary

- Emojis: 🐛 x1
- Categories: Fixes x1

### New features and changes

- [#674](#674) - 🐛 Fix query sample relationships - [8d261b6](8d261b6) by [znatty22](https://github.com/znatty22)
@znatty22 znatty22 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants