♻️ Allow parent or child sample to be null #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont know if we want child sample to ever be null. Just parent? I can't think of a use case where we'd have a parent with null child, only cases where we'd have a child with null parent (being the "top" of the tree) |
calkinsh
requested changes
Jun 11, 2024
calkinsh
approved these changes
Jun 11, 2024
znatty22
added a commit
that referenced
this pull request
Jun 12, 2024
## Release 1.30.0 ### Summary - Emojis: ♻️ x1 - Categories: Additions x1 ### New features and changes - [#672](#672) - ♻️ Allow parent or child sample to be null - [21a6467](21a6467) by [znatty22](https://github.com/znatty22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #671