✨ Add new Sample table and API #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
force-pushed
the
new-sample-table
branch
2 times, most recently
from
bb6dd59 to
23bda81
Compare
awarkow
approved these changes
Feb 6, 2024
Christina-J-Diaz
approved these changes
Feb 6, 2024
calkinsh
approved these changes
Feb 6, 2024
znatty22
force-pushed
the
new-sample-table
branch
from
cabdd88 to
38ce71b
Compare
znatty22
force-pushed
the
new-sample-table
branch
from
38ce71b to
24c56b2
Compare
znatty22
added a commit
that referenced
this pull request
Feb 12, 2024
## Release 1.25.0 ### Summary - Emojis: ✨ x2 - Categories: Additions x2 ### New features and changes - [#646](#646) - ✨ Add new Sample table and API - [76cbf79](76cbf79) by [znatty22](https://github.com/znatty22) - [#642](#642) - ✨ Add preservation method to biospecimen - [f68ba49](f68ba49) by [znatty22](https://github.com/znatty22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dataservice model does not track specimen lineage - which specimens were derived from another (specimen hierarchy tree). See Sample design presentation for design details
Approach
This is an MVP design to satisfy current KF needs and KF Portal Beta requirements. We recognize that this design will not allow one to capture a specimen tree with more than 1 level (e.g. sp1 -> sp2 -sp3).
Sample Table + API
Sample ETL
The Dataservice to Dewrangle CLI will have a command added to it which will pull all biospecimens, derive the parent samples from them, and create the samples in Dataservice
Todo