Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔼 Upgrade migration tooling #613

Closed
wants to merge 6 commits into from
Closed

🔼 Upgrade migration tooling #613

wants to merge 6 commits into from

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented May 10, 2023 •
edited
Loading

Todo

Motivation

We have not upgraded our migration tooling since 2018

Approach

  • Updated migration engine: alembic
    • Includes new auto-generated config (alembic.ini) and script (env.py) in migrations/
  • Updated web framework integration with migration engine: Flask-Migrate
  • ^ Required us to also updated ORM to min version 1.3: SQLAlchemy
  • Fixed some tests that broke bc SQLAlchemy fixed some bugs and is stricter with how it does some things

@znatty22 znatty22 added the refactor Something needs to be done better label May 10, 2023
@znatty22 znatty22 self-assigned this May 10, 2023
@znatty22 znatty22 changed the base branch from master to upgrade-psycopg May 10, 2023 18:53
@znatty22 znatty22 marked this pull request as draft May 10, 2023 19:23
@znatty22 znatty22 force-pushed the upgrade-migration-tooling branch from 024f4ff to 680850f Compare May 10, 2023 20:51
@znatty22 znatty22 marked this pull request as ready for review May 10, 2023 21:09
znatty22 added 2 commits May 15, 2023 12:55
@znatty22
⬆️ Bump click to major v 7
65adfeb
@znatty22
⬆️ Upgrade to latest psycopg2
0e3f2e8 
Current version 2.7.3.2 has issues installing on OSX Ventura
Current version is extremely old (from 2015)
znatty22 added 3 commits May 15, 2023 12:56
@znatty22
⬆️ Upgrade migration tooling
ff475b1 
Upgraded alembic and Flask-Migrate to latest version. This required that
SQLAlchemy be at a min version of 1.3
@znatty22
♻️ Replace autogen migration scripts w new ones
0de5bed
@znatty22
✅ Update tests to fix breaking changes
a2d0350
@znatty22 znatty22 force-pushed the upgrade-migration-tooling branch from 680850f to a2d0350 Compare May 15, 2023 16:56
Base automatically changed from upgrade-psycopg to master May 23, 2023 18:06
@znatty22
Copy link
Member Author

Closing due to change in direction/priorities. We are not moving forward with upgrade. Any upgrade work that we choose to do in the future will be in #608. From there we can cherry pick commits and make PRs against master if we so desire

@znatty22 znatty22 closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-s-friedman chris-s-friedman Awaiting requested review from chris-s-friedman

@wnkhan wnkhan Awaiting requested review from wnkhan

@liberaliscomputing liberaliscomputing Awaiting requested review from liberaliscomputing

Assignees

@znatty22 znatty22

Labels
refactor Something needs to be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@znatty22