🐛 Fix Homo sapiens casing #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liberaliscomputing
force-pushed
the
fix-homo-sapiens-casing
branch
4 times, most recently
from
ba712d5 to
6749308
Compare
liberaliscomputing
force-pushed
the
fix-homo-sapiens-casing
branch
from
6749308 to
2876836
Compare
znatty22
reviewed
May 10, 2021
| depends_on = None | ||
|
|
||
|
|
||
| def upgrade(): |
There was a problem hiding this comment.
Just curious, was this migration completely autogenerated from the change you made to the default for species? Or did you have to manually add the data migration code?
There was a problem hiding this comment.
I did flask db revision and a template file populated with the followings was created:
revision = '12850dab14e9'
down_revision = '025cf1ee0adf'
There was a problem hiding this comment.
Oh I mean did you have to modify what came out of flask db migrate at all?
There was a problem hiding this comment.
Oh, so I modified the following sections:
- module imports: https://github.com/kids-first/kf-api-dataservice/blob/fix-homo-sapiens-casing/migrations/versions/12850dab14e9_.py#L8-L9
- upgrade: https://github.com/kids-first/kf-api-dataservice/blob/fix-homo-sapiens-casing/migrations/versions/12850dab14e9_.py#L22-L29
- downgrade: https://github.com/kids-first/kf-api-dataservice/blob/fix-homo-sapiens-casing/migrations/versions/12850dab14e9_.py#L35-L42
There was a problem hiding this comment.
I don't think anything does data migrations automatically
liberaliscomputing
force-pushed
the
fix-homo-sapiens-casing
branch
from
2876836 to
57e054d
Compare
dankolbman
added a commit
that referenced
this pull request
Jun 3, 2021
## Release 1.13.1 ### Summary - Emojis: 🐛 x1 - Categories: Fixes x1 ### New features and changes - [#575](#575) - 🐛 Fix Homo sapiens casing - [97ea96d](97ea96d) by [liberaliscomputing](https://github.com/liberaliscomputing)
Merged
alubneuski
pushed a commit
that referenced
this pull request
Oct 11, 2024
## Release 1.13.1 ### Summary - Emojis: 🐛 x1 - Categories: Fixes x1 ### New features and changes - [#575](#575) - 🐛 Fix Homo sapiens casing - [97ea96d](97ea96d) by [liberaliscomputing](https://github.com/liberaliscomputing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes/migrates the species enum value of human from
"Homo Sapiens"to"Homo sapiens".