[NT-498] Prevent app freezing with accessibility inspector #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes a app-freezing bug in the simulator when adjusting text size using the accessibility inspector in Manage pledge views.
🤔 Why
Although this didn't appear to be happening on device we do often adjust text sizes with the inspector and this affects our development workflow. Also this seemed to point out something problematic in the layout and warranted further investigation.
🛠 How
guardclause to prevent calculating the thumbnail size whenPledgeDescriptionViewControlleris hidden.We hide
PledgeDescriptionViewControllerwhen we are in any of the Manage pledge flows other than Choose another reward. When this view is hidden it's not necessary to try to calculate the thumbnail size.✅ Acceptance criteria
master. Navigate to Update pledge on a project that you've backed. Open the accessibility inspector and adjust text sizes, the app should freeze.