Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-411, NT-429] Show total amount currency conversion label #913

Merged
merged 14 commits into from
Oct 29, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Oct 25, 2019

📲 What

Shows a currency conversion label beneath the Total amount in the PledgeSummaryViewController if the user's preferred currency is different from the project's currency. If the user does not have a preferred currency set, we use USD to determine whether a conversion label is needed. The conversion label will read About $10.50 and display the converted amount to 2 precision points.

I also removed the + icon from in front of the total amount as part of NT-429.

🤔 Why

To give users a better idea of how much they are pledging, if the project's currency is different from their preferred currency.

🛠 How

  • Added roundingMode, maximumFractionDigits and minimumFractionDigits parameters to our Format.currency function so we can customize these parameters when we format the converted amount.
  • added a new totalConversionLabel to PledgeSummaryViewController

👀 See

Trello, screenshots, external resources?

Pledge Update Logged Out
Simulator Screen Shot - iPhone 8 - 2019-10-25 at 10 26 48 Simulator Screen Shot - iPhone 8 - 2019-10-25 at 10 28 49 Simulator Screen Shot - iPhone 8 - 2019-10-25 at 16 56 25

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

🏎 Performance

N/A

✅ Acceptance criteria

  • Navigate to a project with the same currency as your preferred currency. Select any reward. You should not see a conversion label on the pledge screen.
  • Navigate to a project with a different currency than your preferred currency. Select any reward. You should see a conversion label below the total on the pledge screen.
  • Log out of your account. Then, navigate to a project with a currency that is not USD. Select any reward. You should see a conversion label below the total on the pledge screen.

@ifbarrera ifbarrera marked this pull request as ready for review October 25, 2019 21:09
Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor alphabetizing suggestions

@ifbarrera ifbarrera merged commit 613b50d into master Oct 29, 2019
@ifbarrera ifbarrera deleted the NT-411 branch October 29, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants