-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-411, NT-429] Show total amount currency conversion label #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdolm92
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor alphabetizing suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Shows a currency conversion label beneath the
Total
amount in thePledgeSummaryViewController
if the user's preferred currency is different from the project's currency. If the user does not have a preferred currency set, we useUSD
to determine whether a conversion label is needed. The conversion label will readAbout $10.50
and display the converted amount to 2 precision points.I also removed the
+
icon from in front of the total amount as part of NT-429.🤔 Why
To give users a better idea of how much they are pledging, if the project's currency is different from their preferred currency.
🛠 How
roundingMode
,maximumFractionDigits
andminimumFractionDigits
parameters to ourFormat.currency
function so we can customize these parameters when we format the converted amount.totalConversionLabel
toPledgeSummaryViewController
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
🏎 Performance
N/A
✅ Acceptance criteria