[NT-241] Decimal Pledge Amount in Manage Pledge CTA Fix #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
reviewed
Oct 24, 2019
| @@ -160,3 +157,14 @@ private func subtitle(project: Project, pledgeState: PledgeStateCTAType) -> Stri | |||
| guard let rewardTitle = reward.title else { return "\(amount)" } | |||
| return "\(amount) • \(rewardTitle)" | |||
| } | |||
|
|
|||
| private func formattedPledge(amount: Double, project: Project) -> String { | |||
There was a problem hiding this comment.
Hey @cdolm92, was there a reason for not using an NSNumberFormatter here?
There was a problem hiding this comment.
@justinswart Are we using it to format decimal values elsewhere?
There was a problem hiding this comment.
✅ Convo resolved on slack. The formatter will be added in separate pr. cc: @justinswart
Scollaco
dismissed
their stale review
Will approve once the formatter conversation is resolved.
Scollaco
approved these changes
Oct 24, 2019
…pledge-amount-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Users can now view their pledge amount correctly if they pledged w/ a decimal value.
🤔 Why
Some background context on why the change is needed.
🛠 How
func formattedPledge(amount: Double, project: Project) -> Stringformats the backing amount. If the user backed with a whole amount we drop the decimal places.👀 See
✅ Acceptance criteria