[NT-76] Facebook Log In Copy Updates #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fb-cta-copy-changes
cdolm92
commented
Oct 8, 2019
| _ = self.getNotifiedLabel | ||
| |> baseLabelStyle | ||
| |> UILabel.lens.font %~~ { _, label in | ||
| label.traitCollection.isRegularRegular ? .ksr_headline(size: 15.0) : .ksr_headline(size: 12.0) |
There was a problem hiding this comment.
Opted for headline font here because caption1 caused it wrap due to trucation.
…fb-cta-copy-changes
…fb-cta-copy-changes
…fb-cta-copy-changes
ifbarrera
reviewed
Oct 9, 2019
There was a problem hiding this comment.
I noticed that the PR description says that the facebook button's title should be "Login with Facebook" with the .login intent and Continue with Facebook with the .backProject intent, but it looks like in the screenshots the Facebook button says "Login" 🤔
Can you clarify which one it should be?
| _ = self.getNotifiedLabel | ||
| |> baseLabelStyle | ||
| |> UILabel.lens.font %~~ { _, label in | ||
| label.traitCollection.isRegularRegular ? .ksr_headline(size: 15.0) : .ksr_headline(size: 12.0) |
There was a problem hiding this comment.
Can we try to use a font that doesn't need a size override? So maybe .ksr_subhead().bolded and .ksr_caption1().bolded?
…fb-cta-copy-changes
…fb-cta-copy-changes
…fb-cta-copy-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Facebook log in copy updates in log in/sign up screen for pledge flow.
🛠 How
Facebook button title can either be
Continue with Facebookwhen logged out user is pledging orLog in with Facebookwhen logging in from anywhere else. This is determine w/ theLoginIntent👀 See
✅ Acceptance criteria
Back this ProjectCTA, tapContinuesign up screen should show and facebook button title should beContinue with FacebookLog in with Facebook⏰ TODO