[NT-206] Reward received toggle business logic #866
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,13 +21,14 @@ public protocol ManagePledgeViewModelInputs { | |
| public protocol ManagePledgeViewModelOutputs { | ||
| var configurePaymentMethodView: Signal<GraphUserCreditCard.CreditCard, Never> { get } | ||
| var configurePledgeSummaryView: Signal<Project, Never> { get } | ||
| var configureRewardReceivedWithProject: Signal<Project, Never> { get } | ||
| var configureRewardSummaryView: Signal<Reward, Never> { get } | ||
| var goToCancelPledge: Signal<(Project, Backing), Never> { get } | ||
| var goToChangePaymentMethod: Signal<Void, Never> { get } | ||
| var goToContactCreator: Signal<Void, Never> { get } | ||
| var goToRewards: Signal<Project, Never> { get } | ||
| var goToUpdatePledge: Signal<(Project, Reward), Never> { get } | ||
| var rewardReceivedViewControllerViewIsHidden: Signal<Bool, Never> { get } | ||
| var showActionSheetMenuWithOptions: Signal<[ManagePledgeAlertAction], Never> { get } | ||
| var title: Signal<String, Never> { get } | ||
| } | ||
|
|
@@ -43,6 +44,11 @@ public final class ManagePledgeViewModel: | |
| let projectAndReward = self.projectAndRewardSignal | ||
| .takeWhen(self.viewDidLoadSignal.ignoreValues()) | ||
|
|
||
| let project = projectAndReward.map(first) | ||
| let backing = project | ||
| .map { $0.personalization.backing } | ||
| .skipNil() | ||
|
|
||
| self.title = projectAndReward | ||
| .map(first) | ||
| .map(navigationBarTitle(with:)) | ||
|
|
@@ -55,14 +61,11 @@ public final class ManagePledgeViewModel: | |
| self.configurePledgeSummaryView = projectAndReward | ||
| .map(first) | ||
|
|
||
| self.configureRewardReceivedWithProject = project | ||
|
|
||
| self.configureRewardSummaryView = projectAndReward | ||
| .map(second) | ||
|
|
||
| self.showActionSheetMenuWithOptions = project | ||
| .takeWhen(self.menuButtonTappedSignal) | ||
| .map { project -> [ManagePledgeAlertAction] in | ||
|
|
@@ -93,6 +96,9 @@ public final class ManagePledgeViewModel: | |
| self.goToChangePaymentMethod = self.menuOptionSelectedSignal | ||
| .filter { $0 == .changePaymentMethod } | ||
| .ignoreValues() | ||
|
|
||
| self.rewardReceivedViewControllerViewIsHidden = projectAndReward | ||
| .map { project, reward in reward.isNoReward || project.personalization.backing?.status != .collected } | ||
|
There was a problem hiding this comment. Hopefully this is the same logic @eoji was trying to explain to me ... please let me know if I'm off here |
||
| } | ||
|
|
||
| private let (projectAndRewardSignal, projectAndRewardObserver) = Signal<(Project, Reward), Never>.pipe() | ||
|
|
@@ -118,12 +124,14 @@ public final class ManagePledgeViewModel: | |
|
|
||
| public let configurePaymentMethodView: Signal<GraphUserCreditCard.CreditCard, Never> | ||
| public let configurePledgeSummaryView: Signal<Project, Never> | ||
| public let configureRewardReceivedWithProject: Signal<Project, Never> | ||
| public let configureRewardSummaryView: Signal<Reward, Never> | ||
| public let goToCancelPledge: Signal<(Project, Backing), Never> | ||
| public let goToChangePaymentMethod: Signal<Void, Never> | ||
| public let goToContactCreator: Signal<Void, Never> | ||
| public let goToRewards: Signal<Project, Never> | ||
| public let goToUpdatePledge: Signal<(Project, Reward), Never> | ||
| public let rewardReceivedViewControllerViewIsHidden: Signal<Bool, Never> | ||
| public let showActionSheetMenuWithOptions: Signal<[ManagePledgeAlertAction], Never> | ||
| public let title: Signal<String, Never> | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved the
viewModelto the top of Properties section. This is consistent with the rest of the codebase and makes it easier to glance at the same place where we would in other VC