[NT-226] Cancel backing navigation workflow #860
Conversation
| @@ -32,8 +32,6 @@ extension RewardPledgeNavigationController: UINavigationControllerDelegate { | |||
| case (.pop, is PledgeViewController, is RewardPledgeTransitionAnimatorDelegate): | |||
| return RewardPledgePopTransitionAnimator() | |||
| default: | |||
| // We're not performing any custom transition, bring back the standard divider line | |||
| self.navigationBar.shadowImage = nil | |||
There was a problem hiding this comment.
Removed this line in favor of keeping the shadow for all VCs managed by RewardPledgeNavigationController. This will cause some funkiness with colors in the deprecated pledge VC and possibly the Thanks page, but I think we can easily fix those during a design pass - ideally we can get to a place where there's visual consistency between all the VCs in the checkout flow.
There was a problem hiding this comment.
Can you describe what funkiness do you have in mind? 😄
There was a problem hiding this comment.
I believe what might happen is the line won't come back in the Thanks VC after checkout. What I think we should do is do a light colors pass on the Thanks screen to make it visually consistent with the other screens in the new checkout flow.
| public protocol CancelPledgeViewModelInputs { | ||
| func configure(with project: Project, backing: Backing) | ||
| func viewDidLoad() | ||
| } |
There was a problem hiding this comment.
The order here is different. Inputs should go before the Outputs
…cancel-backing-setup
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
| @@ -32,8 +32,6 @@ extension RewardPledgeNavigationController: UINavigationControllerDelegate { | |||
| case (.pop, is PledgeViewController, is RewardPledgeTransitionAnimatorDelegate): | |||
| return RewardPledgePopTransitionAnimator() | |||
| default: | |||
| // We're not performing any custom transition, bring back the standard divider line | |||
| self.navigationBar.shadowImage = nil | |||
There was a problem hiding this comment.
Can you describe what funkiness do you have in mind? 😄
📲 What
Creates
CancelPledgeViewControlleralong withCancelPledgeViewModeland test setup. ConfiguresManagePledgeViewControllerto push this new VC onto the stack whenCancel pledgeis selected from the action sheet menu.🤔 Why
Setup for cancel pledge.
👀 See
♿️ Accessibility
✅ Acceptance criteria