[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855

ifbarrera · 2019-09-26T21:07:58Z

📲 What

Hooks up the createBacking mutation to the pledge button to allow users to create backings natively.

🤔 Why

So that users can pledge with a stored card.

🛠 How

When the pledge button is tapped, a request is made to the createBacking mutation which creates the pledge. On success, the user is taken to the "Thanks" screen. If an error occurs, the error is displayed in the message banner on the Pledge Screen.

Things to note:

this PR does not include a loading state for when the request is in flight
this PR does not take ino account validation of the pledge amount
some of this code will be refactored in the near future once we merge the createApplePayBacking mutation into the createBacking mutation
there's an unrelated but where the first credit card is selected but the pledge button is not enabled. It'll be addressed in separate PR

👀 See

Create Backing Success	Create Backing Failure

✅ Acceptance criteria

Navigate to the pledge screen on an account with stored cards. Select a stored card (the pledge button should become enabled). Then tap "Pledge", after a couple seconds you should redirected to the "Thanks" screen.
Navigate to the pledge screen on an account with stored cards. Using the network link conditioner, disable your network to 100% loss. Select a card and tap "Pledge". After about 30 seconds, you should see the error banner with the message "Sorry, something went wrong". Note you won't see any sort of loading state, so you just have to wait until the banner shows up.
Testing RefParam
Navigate to the pledge screen on an account with stored cards. Select a stored card (the pledge button should become enabled). Then tap "Pledge", after a couple seconds you should redirected to the "Thanks" screen. In the console, you should see the logs which include the input for the createBacking mutation, which should show a refParam input field a value (ex. discovery_home, recommendations).

…pledge-button-interaction # Conflicts: # Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift

ifbarrera · 2019-09-27T14:27:23Z

KsApi/mutations/inputs/CreateBackingInput.swift

@@ -4,31 +4,32 @@ public struct CreateBackingInput: GraphMutationInput {
  let amount: String
  let locationId: String?
  let paymentSourceId: String
-  let paymentType: String


Removed paymentType because after chatted with the backend team, it's not really an input field (should always be set to credit_card). They plan on removing the field entirely in the near future.

ifbarrera · 2019-09-27T14:29:29Z

Library/CreateBackingInput+Constructor.swift

+    refTag: RefTag?,
+    paymentSourceId: String
+  ) -> CreateBackingInput {
+    let pledgeAmountDecimal = Decimal(pledgeAmount)


A lot of this is duplicated from CreateApplePayBackingInput - I decided not to refactor out the shared parts because I know we're planning to consolidate the two mutations in the near future. When we do, we can simply merge the differences from CreateApplePayInput into this input.

ifbarrera · 2019-09-27T14:31:21Z

Library/ViewModels/PledgeViewModel.swift

+      .map(CreateBackingInput.input(from:reward:pledgeAmount:selectedShippingRule:refTag:paymentSourceId:))
+      .switchMap { input in
+        AppEnvironment.current.apiService.createBacking(input: input)
+          .ksr_delay(AppEnvironment.current.apiDelayInterval, on: AppEnvironment.current.scheduler)


Notice that we don't care about the result here - since we are moving to a synchronous createBacking mutation, any errors in creating the pledge should come back as regular graph errors.

justinswart

Great work on this! Appears to do exactly what is says on the tin!

Worth noting that I entered a pledge amount of 0 and could still hit the button and got an 'Oops, something went wrong error'. But as you mention - this will be resolved in follow-up PRs.

justinswart · 2019-09-27T17:39:17Z

Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift

+
+  func pledgePaymentMethodsViewControllerDidTapPledgeButton(
+    _
+    viewController: PledgePaymentMethodsViewController


I know how much you love formatting comments but this is strange 😄

justinswart · 2019-09-27T17:41:44Z

Kickstarter-iOS/Views/Controllers/PledgeViewController.swift

+
+  func pledgePaymentMethodsViewControllerDidTapPledgeButton(
+    _:
+    PledgePaymentMethodsViewController


justinswart · 2019-09-27T17:52:07Z

KsApi/mutations/inputs/CreateBackingInput.swift

  }

  public func toInputDictionary() -> [String: Any] {
    var inputDictionary = [
      "amount": amount,
      "paymentSourceId": paymentSourceId,
-      "paymentType": paymentType,
+      // swiftlint:disable:next line_length
+      "paymentType": "credit_card", // this is temporary and will be removed once the mutation has been updated


I'm guessing we can flag the PaymentType enum for removal too?

Oh yeah good call.

ifbarrera added 4 commits September 26, 2019 11:00

Create Backing

c4b5f15

Create Backing Tests

44fe8e6

Formatting

70daa6c

Merge branch 'master' of https://github.com/kickstarter/ios-oss into …

dceb6d0

…pledge-button-interaction # Conflicts: # Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift

ifbarrera assigned justinswart Sep 26, 2019

ifbarrera added the needs review label Sep 26, 2019

ifbarrera changed the title ~~[NT-209] Pledge Button Interaction (Create Backing)~~ [NT-209, NT-156] Pledge Button Interaction (Create Backing) Sep 26, 2019

ifbarrera commented Sep 27, 2019

View reviewed changes

justinswart approved these changes Sep 27, 2019

View reviewed changes

ifbarrera added 2 commits September 27, 2019 14:52

Fix formatting issues

db19969

Use paymentType instead of string

ee58c06

ifbarrera requested a review from justinswart September 27, 2019 19:01

ifbarrera added 2 commits September 27, 2019 15:01

Merge branch 'master' into pledge-button-interaction

6201b78

Merge branch 'master' into pledge-button-interaction

8794683

justinswart approved these changes Sep 27, 2019

View reviewed changes

ifbarrera merged commit 57ddae9 into master Sep 27, 2019

ifbarrera deleted the pledge-button-interaction branch September 27, 2019 21:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855

[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855

ifbarrera commented Sep 26, 2019 •

edited by justinswart

Loading

ifbarrera Sep 27, 2019

ifbarrera Sep 27, 2019

ifbarrera Sep 27, 2019

justinswart left a comment

justinswart Sep 27, 2019

ifbarrera Sep 27, 2019

justinswart Sep 27, 2019

justinswart Sep 27, 2019

ifbarrera Sep 27, 2019

[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855

[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855

Conversation

ifbarrera commented Sep 26, 2019 • edited by justinswart Loading

📲 What

🤔 Why

🛠 How

👀 See

✅ Acceptance criteria

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinswart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ifbarrera commented Sep 26, 2019 •

edited by justinswart

Loading