[NT-312] Pledge amount invalid input color #849
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import UIKit | ||
|
|
||
| extension UITraitCollection { | ||
| static let allCases: [UITraitCollection] = [ | ||
|
There was a problem hiding this comment. Just a test helper for allowing us testing large text better. |
||
| UITraitCollection(preferredContentSizeCategory: .extraSmall), | ||
| UITraitCollection(preferredContentSizeCategory: .small), | ||
| UITraitCollection(preferredContentSizeCategory: .medium), | ||
| UITraitCollection(preferredContentSizeCategory: .large), | ||
| UITraitCollection(preferredContentSizeCategory: .extraLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .extraExtraLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .extraExtraExtraLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .accessibilityMedium), | ||
| UITraitCollection(preferredContentSizeCategory: .accessibilityLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .accessibilityExtraLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .accessibilityExtraExtraLarge), | ||
| UITraitCollection(preferredContentSizeCategory: .accessibilityExtraExtraExtraLarge) | ||
| ] | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| @testable import Kickstarter_Framework | ||
| @testable import Library | ||
| @testable import KsApi | ||
| import Prelude | ||
| import UIKit | ||
|
|
||
| final class PledgeAmountViewControllerTests: TestCase { | ||
|
There was a problem hiding this comment. I felt like it was a perfect opportunity to add testing...not only can we test large text but also invalid input values, currency symbol, stepper increment/decrement button etc. |
||
| override func setUp() { | ||
| super.setUp() | ||
|
|
||
| AppEnvironment.pushEnvironment(mainBundle: Bundle.framework) | ||
| UIView.setAnimationsEnabled(false) | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| AppEnvironment.popEnvironment() | ||
| UIView.setAnimationsEnabled(true) | ||
|
|
||
| super.tearDown() | ||
| } | ||
|
|
||
| func testView() { | ||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: .template, reward: .template)) | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
|
|
||
| func testView_LargerText() { | ||
| UITraitCollection.allCases.forEach { additionalTraits in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(child: controller, additionalTraits: additionalTraits) | ||
| parent.view.frame.size.height = 300 | ||
|
|
||
| controller.configureWith(value: (project: .template, reward: .template)) | ||
|
|
||
| FBSnapshotVerifyView( | ||
| parent.view, identifier: "trait_\(additionalTraits.preferredContentSizeCategory.rawValue)" | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| func testView_ShowsCurrencySymbol() { | ||
| let project = Project.template | ||
| |> Project.lens.country .~ Project.Country.ca | ||
|
|
||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: project, reward: .template)) | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
|
|
||
| func testView_StepperDecrementButtonDisabled_WhenStepperValueSetToMinimum() { | ||
| let reward = Reward.template | ||
| |> Reward.lens.minimum .~ 0 | ||
|
|
||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: .template, reward: reward)) | ||
| controller.stepperValueChanged(UIStepper(frame: .zero) |> \.value .~ 0) | ||
| controller.textFieldDidChange(UITextField(frame: .zero) |> \.text .~ "0") | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
|
|
||
| func testView_StepperIncrementButtonDisabled_WhenStepperValueSetToMaximum() { | ||
| let stepper = UIStepper(frame: .zero) | ||
| |> \.maximumValue .~ Double.greatestFiniteMagnitude | ||
| |> \.value .~ Double.greatestFiniteMagnitude | ||
|
|
||
| let textField = UITextField(frame: .zero) | ||
| |> \.text .~ String(format: "%.0f", Double.greatestFiniteMagnitude) | ||
|
|
||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: .template, reward: .template)) | ||
| controller.stepperValueChanged(stepper) | ||
| controller.textFieldDidChange(textField) | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
|
|
||
| func testView_TextColorIsRedWhenBellowMinimum() { | ||
| let reward = Reward.template | ||
| |> Reward.lens.minimum .~ 10 | ||
|
|
||
| let stepper = UIStepper(frame: .zero) | ||
| |> \.value .~ 5 | ||
|
|
||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: .template, reward: reward)) | ||
| controller.stepperValueChanged(stepper) | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
|
|
||
| func testView_TextColorIsRedWhenAboveMaximum() { | ||
| let project = Project.template | ||
| |> (Project.lens.country .. Project.Country.lens.maxPledge) .~ 10_000 | ||
|
|
||
| let stepper = UIStepper(frame: .zero) | ||
| |> \.maximumValue .~ Double.greatestFiniteMagnitude | ||
| |> \.value .~ Double.greatestFiniteMagnitude | ||
|
|
||
| [Device.phone4_7inch, Device.pad].forEach { device in | ||
| let controller = PledgeAmountViewController.instantiate() | ||
| let (parent, _) = traitControllers(device: device, orientation: .portrait, child: controller) | ||
| parent.view.frame.size.height = 100 | ||
|
|
||
| controller.configureWith(value: (project: project, reward: .template)) | ||
| controller.stepperValueChanged(stepper) | ||
|
|
||
| FBSnapshotVerifyView(parent.view, identifier: "device_\(device)") | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that it builds on Circle and not on my machine. I wonder what's the real problem here. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash in this file should match the one in the
Cartfile.