🐞[Bug] Force UserAgent value in AJAX requests #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcreux
reviewed
Aug 4, 2019
Co-Authored-By: Philippe Creux <pcreux@gmail.com>
ifbarrera
approved these changes
Aug 5, 2019
|
Well that was easy. |
justinswart
added a commit
that referenced
this pull request
Aug 7, 2019
* Force UserAgent value in UserDefaults * Update KsApi/Service.swift Co-Authored-By: Philippe Creux <pcreux@gmail.com> * SwiftFormat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Forces the user agent for all requests to be our custom user agent which has the format:
"\(app)/\(bundleVersion) (\(model); iOS \(systemVersion) Scale/\(scale))"As defined here.
🤔 Why
Our
Completed Checkouttracking event has been broken on iOS for some time due to that call being made in a webview via an AJAX request rather than a standard request which we could modify by intercepting theNSURLRequestobject.By injecting the custom user agent the back-end will track the request as being a native app request.
🛠 How
Added what appears to be a common workaround for this which is to set a value in
UserDefaultsforUserAgent(note: no hyphen).👀 See
Charles Proxy screenshots testing on simulator:
✅ Acceptance criteria