Add new header to readme #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the old green wordmark with the new green app icon from #707
|
Hey @dannyalright I'm actually in favour of keeping the wordmark and maybe just changing the colour? Unless you have strong feelings about replacing it with the icon? |
|
Copy that. No strong feelings—I was going for more of the app vibe over the company vibe. I'll update the colour of the wordmark, maybe shrink it a bit, and then update the PR. |
|
how's that, @justinswart ? |
|
Yeah I like that - do you want to open one on https://github.com/kickstarter/android-oss too, that repo is currently the same as this one? @eoji you dig? |
justinswart
approved these changes
Jun 18, 2019
|
yeah @dannyalright and I are pairing on the new icon tomorrow AM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Replace the old green wordmark with the new green app icon (#707).
🤔 Why
🛠 How
Changing the SVG to a PNG (because of shadows).
👀 See
📝 Notes
Added @justinswart as a reviewer as he added the logo originally and has been dealing with my app icon madness.