Settings Dynamic Type Fixes

[ifbarrera]

📲 What

Fixes a bug that prevented fonts in settings from resizing correctly with dynamic type. Also turns off font resizing on the LoadingBarButtonItemView since it's a navigation item.

🛠 How

A deep-dive done by @dusi into dynamic type within Settings identified a bug where several labels whose fonts were set using our custom .ksr_() functions were not resizing correctly when the font size was changed using the accessibility inspector. An investigation showed that this was due to the helper styling functions in SettingsStyles.swift capturing the current context which essentially cached the initial preferredFont instead of re-evaluating it every time bindStyles was called.

The solution was to convert the SettingsStyles helpers that are setting a font into a closure that takes a label and applies the styles within the closure.

👀 See

Before:

• notice that although the section footers resize, the title labels for the settings cells do not
• notice that the "Save" button resizes even though it shouldn't

After:

• notice that all cell titles now resize
• notice that the "Save" button no longer resizes

Before 🐛	After 🦋

♿️ Accessibility

• Works with VoiceOver
• Supports Dynamic Type

✅ Acceptance criteria

• Run the app with the accessibility inspector. Then use the accessibility inspector to increase the font size. Navigate to Settings. Cell titles in all settings cells should now resize.
• Run the app with the accessibility inspector. Then use the accessibility inspector to increase the font size. Navigate to Settings -> Account -> Change Password. The Save button on the top right should not resize.
• Run the app with the accessibility inspector. Then use the accessibility inspector to increase the font size. Navigate to Settings -> Account -> Change Email. The Save button on the top right should not resize.

[ifbarrera]

[Dynamic Type Fixes] Settings cell titles should resize

[ifbarrera]

[Dynamic Type Fixes] Save Button should not resize

[dusi]

🚢 🚢 🚢

[dusi]

Moving these 2 will probably cause some merge conflicts on the Create password branch but now that we know about it we should be able to resolve it just fine!