Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use environment var for match username #624

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Use environment var for match username #624

merged 1 commit into from
Mar 2, 2019

Conversation

justinswart
Copy link
Contributor

📲 What

Retrieves the Apple ID username for match from an environment variable instead of being hard-coded.

🤔 Why

We've updated the Apple ID for our CI purposes and we would prefer to retrieve this value from an environment variable going forward. We do this elsewhere in our Fastfile so it makes sense to be consistent.

🛠 How

  • Updated the var on CircleCI.
  • Added it to our match arguments.

@justinswart justinswart requested a review from ifbarrera March 1, 2019 23:55
@justinswart justinswart merged commit 4923361 into master Mar 2, 2019
@justinswart justinswart deleted the use-env-var-match branch March 2, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbarrera ifbarrera ifbarrera approved these changes

Assignees

@dusi dusi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinswart @ifbarrera @dusi