-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project Activity] Updated Email Frequency in Settings #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦pledge-activity-digest
Scollaco
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, @cdolm92 . Looks good to me π
β¦pledge-activity-digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π² What
Replacing creator digest w/ project summary that gets sent to creators twice a day or daily. This PR also removes Like email notifications.
π See
See snapshots below.
β Acceptance criteria
Test Change Email Frequency
Settings > Notifications
Project Activity
email icon. If disabledEmail Frequency
should not appear, if enabledEmail Frequency
should show. Tap theProject Activity
email icon a few times to make sure it behaves as expected.Project Activity
to enable email notifications. Then tapEmail Frequency
a picker should show.Twice a day summary
orDaily Summary
. Picker should dismiss and you should see the set value on theEmail Frequency
. Test a few times, try navigating away from screen to make sure values are correct.Test picker dismissal
Settings > Notifications
Project Activity
to enable email notifications. Then tapEmail Frequency
a picker should showTest icon animation
Settings > Notifications
tap on each cell w/ an email and mobile icon. They should animate.