Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project Activity] Updated Email Frequency in Settings #576

Merged
merged 12 commits into from
Feb 12, 2019

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Feb 5, 2019

πŸ“² What

Replacing creator digest w/ project summary that gets sent to creators twice a day or daily. This PR also removes Like email notifications.

πŸ‘€ See

See snapshots below.

βœ… Acceptance criteria

Test Change Email Frequency

  • Navigate toSettings > Notifications
  • Tap theProject Activity email icon. If disabled Email Frequency should not appear, if enabled Email Frequency should show. Tap the Project Activity email icon a few times to make sure it behaves as expected.
  • Tap the Project Activity to enable email notifications. Then tap Email Frequency a picker should show.
  • Switch the picker to Twice a day summary or Daily Summary. Picker should dismiss and you should see the set value on the Email Frequency. Test a few times, try navigating away from screen to make sure values are correct.

Test picker dismissal

  • Navigate toSettings > Notifications
  • Tap the Project Activity to enable email notifications. Then tap Email Frequency a picker should show
  • Tap anywhere(* will not dismiss if you tap on a cell) to dismiss
  • Picker should dismiss

Test icon animation

  • In Settings > Notifications tap on each cell w/ an email and mobile icon. They should animate.

@cdolm92 cdolm92 added WIP blocked a PR that is blocked for external reasons labels Feb 5, 2019
@cdolm92 cdolm92 removed the blocked a PR that is blocked for external reasons label Feb 8, 2019
@cdolm92 cdolm92 changed the title [WIP]Pledge activity digest [Project Activity] Project Activity Feb 8, 2019
@cdolm92 cdolm92 changed the title [Project Activity] Project Activity [Project Activity] Updated Email Frequency in Setting Feb 8, 2019
@cdolm92 cdolm92 changed the title [Project Activity] Updated Email Frequency in Setting [Project Activity] Updated Email Frequency in Settings Feb 8, 2019
@cdolm92 cdolm92 requested a review from Scollaco February 8, 2019 18:00
@cdolm92 cdolm92 added needs review and removed WIP labels Feb 8, 2019
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @cdolm92 . Looks good to me πŸ‘

@cdolm92 cdolm92 merged commit 52bc11d into master Feb 12, 2019
@cdolm92 cdolm92 deleted the pledge-activity-digest branch February 12, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants