[MBL-1783] Don't filter local pickup based on shipping rule #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Previously, we handled local pickup rewards similar to shippable rewards, and required them to match the shipping rule's location. Now we handle them similar to digital rewards instead (they'll always show as a pledge option).
This pr also the reward summary table, which was waiting for a non-nil shipping rule before showing up.
🤔 Why
With the previous setup, we don't include local pickup rewards when determining what locations are selectable. If a project had only local pickup rewards, we filtered out all rewards except the "no reward" option on iOS, with no way to unhide them (the shipping location selector only shows if there's at least one shippable reward).
✅ Acceptance criteria
⏰ TODO
Not in this pr, I'm going to file a ticket (if we don't already have one) to add the local pickup view back in to the pledge screen UI. The current UI does not make the "local pickup" part clear enough.Created MBL-1784 to track this.