[MBL-1783 Unhide rewards immediately if there's no shippable rewards #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Oct 16, 2024
| guard let self else { return } | ||
|
|
||
| self.collectionView.isHidden = !shimmerLoadingViewIsHidden | ||
| self.collectionView.layoutIfNeeded() |
There was a problem hiding this comment.
I deleted this because now that we're not always waiting for the location view to load, it gets called before the view hierarchy is ready. I did test a bunch of random projects (hence the local pickup bug I found) and didn't see any UI weirdness caused by removing this line.
stevestreza-ksr
approved these changes
Oct 16, 2024
| guard let self else { return } | ||
|
|
||
| self.collectionView.isHidden = !shimmerLoadingViewIsHidden | ||
| self.collectionView.layoutIfNeeded() | ||
| self.collectionView.isHidden = rewardsCollectionViewIsHidden |
There was a problem hiding this comment.
Making sure the intent was to invert this isHidden check
There was a problem hiding this comment.
Yeah, I found the naming to be super confusing before, so I've inverted it (both here and in the view model) to be more intuitive. It's still in sync with the underlying value; it's just the output signal value that's inverted. Thanks for checking though!
scottkicks
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We currently hide all rewards until the shipping location selector is done loading. If there aren't any shippable rewards, unhide the rewards immediately.
👀 See
Jira
✅ Acceptance criteria