[MBL-1501] PPO view model navigation events #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
requested changes
Sep 26, 2024
There was a problem hiding this comment.
I like the way navigation is set up! I don't think I've seen multiple views access the same view model in our code before, but it's clean and simple and I like it (apart from the one name that I think is confusing). I'm concerned about the alert dot/badges; if you want to either tag TODOs for those or split those changes into a separate pr, I'd be happy to approve this one.
Kickstarter-iOS/Features/PledgedProjectsOverview/PPOContainerViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgedProjectsOverview/PPOContainerViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgedProjectsOverview/PPOContainerViewController.swift
Show resolved
Hide resolved
stevestreza-ksr
force-pushed
the
stevestreza/ppo/view-model-routes
branch
from
7ab8d14 to
460ccb7
Compare
ifosli
approved these changes
Oct 3, 2024
Kickstarter-iOS/Features/PledgedProjectsOverview/PPOEmptyStateView.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgedProjectsOverview/PPOViewModelTests.swift
Show resolved
Hide resolved
…PPOView for new view model Add a new property 'ppoViewModel' to PPOContainerViewController. Modify the initialization of PPOView in PPOContainerViewController to use the new view model. Update the sink method in PPOContainerViewController to set badge and paged view controllers based on results. Change the declaration of viewModel in PPOView to be a binding.
stevestreza-ksr
force-pushed
the
stevestreza/ppo/view-model-routes
branch
from
1753b04 to
43df552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Implements most of the logic for navigation events in the PPO view model and the tab bar integration.
🛠 How
Each user interaction was added to the PPOViewModel separately, with separate subjects to represent each type of user interaction. This will let us handle navigation events and analytics separately.
A
PPONavigationEventenum was added to represent different locations the user might navigate to. Then, the individual subjects are mapped to their respective navigation events, and those get merged into a navigationEvents publisher.Contextual information for routing locations (e.g. which project was backed) and handling of routing will be added once we connect this to a navigation service in MBL-1451).
Unit tests were added to cover these inputs and their navigation events.
✅ Acceptance criteria
All tests should pass.