Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1736] Include Shipping In Pledge Total When It Exists #2158

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Sep 18, 2024

📲 What

In the new flow (that also supports estimated shipping), a reward that charges shipping at pledge cannot be pledged to. We’re not including the shipping cost in the total (or displaying it to users), so trying to pledge leads to a backend error saying that the total cost is too small.

🤔 Why

Projects that are charging shipping should still allow backers to pledge.

🛠 How

Include the shipping total in the pledge total when it exists and make sure the summary table shows the shipping total as well.

✅ Acceptance criteria

  • Pledging to a project that charges shipping, when the "no shipping at checkout" flag is on, succeeds, and includes shipping in the pledge total
  • Pledging to a project that does not charge shipping (only estimated shipping), when the "no shipping at checkout" flag is on, succeeds, and does not shipping in the pledge total
  • Late pledge flow is un changes

@scottkicks scottkicks marked this pull request as ready for review September 18, 2024 17:53
@scottkicks scottkicks requested a review from ifosli September 18, 2024 17:53
@scottkicks scottkicks merged commit ed0637d into main Sep 18, 2024
5 checks passed
@scottkicks scottkicks deleted the newFlowShipping branch September 18, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants