Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1719] Include Selected Reward Quantities In Total Estimated Shipping Range #2152

Merged
merged 3 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions Library/SharedFunctions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,13 @@ public func isRewardDigital(_ reward: Reward?) -> Bool {
public func estimatedShippingText(
for rewards: [Reward],
project: Project,
selectedShippingRule: ShippingRule
selectedShippingRule: ShippingRule,
selectedQuantities: SelectedRewardQuantities? = nil
) -> String? {
let (estimatedMin, estimatedMax) = estimatedMinMax(
from: rewards,
selectedShippingRule: selectedShippingRule
selectedShippingRule: selectedShippingRule,
selectedQuantities: selectedQuantities
)

guard estimatedMin > 0, estimatedMax > 0 else { return nil }
Expand Down Expand Up @@ -699,13 +701,15 @@ public func estimatedShippingText(
public func estimatedShippingConversionText(
for rewards: [Reward],
project: Project,
selectedShippingRule: ShippingRule
selectedShippingRule: ShippingRule,
selectedQuantities: SelectedRewardQuantities? = nil
) -> String? {
guard project.stats.needsConversion else { return nil }

let (estimatedMin, estimatedMax) = estimatedMinMax(
from: rewards,
selectedShippingRule: selectedShippingRule
selectedShippingRule: selectedShippingRule,
selectedQuantities: selectedQuantities
)

guard estimatedMin > 0, estimatedMax > 0 else { return nil }
Expand Down Expand Up @@ -751,7 +755,8 @@ public func attributedCurrency(withProject project: Project, total: Double) -> N

private func estimatedMinMax(
from rewards: [Reward],
selectedShippingRule: ShippingRule
selectedShippingRule: ShippingRule,
selectedQuantities: SelectedRewardQuantities?
) -> (Double, Double) {
var min: Double = 0
var max: Double = 0
Expand All @@ -777,8 +782,8 @@ private func estimatedMinMax(
return
}

min += estimatedMin
max += estimatedMax
min += estimatedMin * Double(selectedQuantities?[reward.id] ?? 1)
max += estimatedMax * Double(selectedQuantities?[reward.id] ?? 1)
}

return (min, max)
Expand Down
34 changes: 34 additions & 0 deletions Library/SharedFunctionsTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -725,4 +725,38 @@ final class SharedFunctionsTests: TestCase {

XCTAssertEqual(estimatedShipping, "$3-$12")
}

func test_estimatedShippingText_IncludesSelectedQuantities() {
let rewardShippingRule = ShippingRule.template
|> ShippingRule.lens.estimatedMin .~ Money(amount: 1)
|> ShippingRule.lens.estimatedMax .~ Money(amount: 10)
let addOnShippingRule = ShippingRule.template
|> ShippingRule.lens.estimatedMin .~ Money(amount: 1)
|> ShippingRule.lens.estimatedMax .~ Money(amount: 5)

let reward = Reward.template
|> Reward.lens.shipping .~ (.template |> Reward.Shipping.lens.enabled .~ true)
|> Reward.lens.shippingRules .~ [rewardShippingRule]
|> Reward.lens.id .~ 99
let addOn = Reward.template
|> Reward.lens.shipping .~ (.template |> Reward.Shipping.lens.enabled .~ true)
|> Reward.lens.id .~ 5
|> Reward.lens.shippingRules .~ [addOnShippingRule]

let project = Project.template

let selectedQuantities: SelectedRewardQuantities = [
reward.id: 1,
addOn.id: 2
]

let estimatedShipping = estimatedShippingText(
for: [reward, addOn],
project: project,
selectedShippingRule: .template,
selectedQuantities: selectedQuantities
)

XCTAssertEqual(estimatedShipping, "$3-$20")
}
}
29 changes: 22 additions & 7 deletions Library/ViewModels/NoShippingPledgeViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -313,15 +313,30 @@ public class NoShippingPledgeViewModel: NoShippingPledgeViewModelType, NoShippin
self.pledgeDisclaimerViewDidTapLearnMoreSignal.mapConst(.trust)
)

self.configureEstimatedShippingView = Signal.combineLatest(project, rewards, selectedShippingRule)
.map { project, rewards, shippingRule in
guard let rule = shippingRule else { return (nil, nil) }
self.configureEstimatedShippingView = Signal.combineLatest(
project,
rewards,
selectedShippingRule,
selectedQuantities
)
.map { project, rewards, shippingRule, selectedQuantities in
guard let rule = shippingRule else { return (nil, nil) }

return (
estimatedShippingText(for: rewards, project: project, selectedShippingRule: rule),
estimatedShippingConversionText(for: rewards, project: project, selectedShippingRule: rule)
return (
estimatedShippingText(
for: rewards,
project: project,
selectedShippingRule: rule,
selectedQuantities: selectedQuantities
),
estimatedShippingConversionText(
for: rewards,
project: project,
selectedShippingRule: rule,
selectedQuantities: selectedQuantities
)
}
)
}

self.estimatedShippingViewHidden = Signal.combineLatest(self.configureEstimatedShippingView, baseReward)
.map { estimatedShippingStrings, reward in
Expand Down
32 changes: 24 additions & 8 deletions Library/ViewModels/NoShippingPostCampaignCheckoutViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public class NoShippingPostCampaignCheckoutViewModel: NoShippingPostCampaignChec
let baseReward = initialData.map(\.rewards).map(\.first)
let project = initialData.map(\.project)
let selectedShippingRule = initialData.map(\.selectedShippingRule)
let selectedQuantities = initialData.map(\.selectedQuantities)

self.configurePaymentMethodsViewControllerWithValue = Signal.combineLatest(initialData, checkoutId)
.compactMap { data, checkoutId -> PledgePaymentMethodsValue? in
Expand Down Expand Up @@ -109,15 +110,30 @@ public class NoShippingPostCampaignCheckoutViewModel: NoShippingPostCampaignChec
)
}

self.configureEstimatedShippingView = Signal.combineLatest(project, rewards, selectedShippingRule)
.map { project, rewards, shippingRule in
guard let rule = shippingRule else { return (nil, nil) }

return (
estimatedShippingText(for: rewards, project: project, selectedShippingRule: rule),
estimatedShippingConversionText(for: rewards, project: project, selectedShippingRule: rule)
self.configureEstimatedShippingView = Signal.combineLatest(
project,
rewards,
selectedShippingRule,
selectedQuantities
)
.map { project, rewards, shippingRule, selectedQuantities in
guard let rule = shippingRule else { return (nil, nil) }

return (
estimatedShippingText(
for: rewards,
project: project,
selectedShippingRule: rule,
selectedQuantities: selectedQuantities
),
estimatedShippingConversionText(
for: rewards,
project: project,
selectedShippingRule: rule,
selectedQuantities: selectedQuantities
)
}
)
}

self.estimatedShippingViewHidden = Signal.combineLatest(self.configureEstimatedShippingView, baseReward)
.map { estimatedShippingStrings, reward in
Expand Down