[MBL-1675] Update add-ons CTA #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Sep 3, 2024
| self.configureContinueCTAViewWithDataQuantity.assertLastValue(5) | ||
| self.configureContinueCTAViewWithDataIsValid.assertLastValue(true) | ||
| self.configureContinueCTAViewWithDataIsLoading.assertLastValue(false) | ||
| XCTAssertEqual(self.configureContinueCTAViewWithDataPledgeAmount.lastValue??.string, "$60.00") |
There was a problem hiding this comment.
Note: I've updated these and similar tests to only check the last value instead of asserting all values, since adding the total here about doubles the amount of value changes (any time bonus support or add-ons change, so does the total). I found just checking the last value to be more useful and more clear.
scottkicks
requested changes
Sep 3, 2024
There was a problem hiding this comment.
It looks like the label and amount font sizes might be slightly off from the designs. And also I think the amount should be rounded to the nearest dollar.
from the designs
There was a problem hiding this comment.
Yeah, I asked Alison about this and she said to match the current styling for the total so I'm pretty sure we want to do that for the font as well!
scottkicks
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Update the add-ons CTA to include the pledge amount (in the no shipping at pledge flow). For simplicity, this also moves some pledge-flow CTA styles to be shared.
👀 See
Jira
See snapshots for the before/after.
✅ Acceptance criteria