[MBL-1684] Remove Redundant No Shipping At Checkout Feature Flag Checks #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this VC is only instantiated when featureNoShippingAtCheckout is enabled so we can remove the extra conditionals and this method since we don't want to go to confirm details at all from here anymore
This class is only instantiated when featureNoShippingAtCheckout is disabled. The check happens on the project page so no need to do it here.
scottkicks
commented
Aug 29, 2024
Comment on lines
160
to
164
| assert( | ||
| topViewController is PledgeViewController || | ||
| topViewController is NoShippingPledgeViewController || | ||
| topViewController is PostCampaignCheckoutViewController, | ||
| "PledgePaymentMethodsViewController is only intended to be presented as part of a pledge flow." |
There was a problem hiding this comment.
We need to add this type-check here so that the Stripe payment sheet is presented on the NoShippingPledgeViewController
scottkicks
commented
Aug 29, 2024
| } | ||
|
|
||
| self.viewModel.outputs.goToPledge | ||
| self.viewModel.outputs.goToCustomizeYourReward |
There was a problem hiding this comment.
Updated the name of this output because this is called anytime a nonshippable reward is selected taking the user to the screens that only have the pledge amount or bonus amount selectors shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Removes Redundant
featureNoShippingAtCheckoutChecksAlso does a quick fix for an issue found in QA for the Stripe Sheet not showing on
NoShippingPledgeViewController.🤔 Why
The
ProjectPageVIewControllerdetermines whether to start the "No Shipping At Checkout" flow or the current flow in Production.We have unnecessary
if featureNoShippingAtCheckout()conditions in the "No Shipping At Checkout" View Controllers.Since they'll never be shown when the flag is disabled, I'm removing them. They should never have been here tbh.
This all cleanup work.
🛠 How
Goes through each of these VCs and removes unused code and unnecessary feature flag checks:
✅ Acceptance criteria
featureNoShippingAtCheckoutis OFFfeatureNoShippingAtCheckoutis ON