[MBL-1458 pt 1] Add alert flag for PPO #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevestreza-ksr
changed the title
Kickstarter-iOS/Features/PledgedProjectsOverview/CardView/PPOAlertFlag.swift
Show resolved
Hide resolved
ifosli
approved these changes
Aug 19, 2024
Kickstarter-iOS/Features/PledgedProjectsOverview/CardView/PPOAlertFlag.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgedProjectsOverview/CardView/PPOAlertFlag.swift
Show resolved
Hide resolved
Kickstarter-iOS/Features/PledgedProjectsOverview/CardView/PPOAlertFlag.swift
Show resolved
Hide resolved
… into stevestreza/ppo/card-alert-flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This PR implements the alert flag for the card view for pledged projects, as well as the relevant subviews. It adds a view model to cover handling actions like tapping buttons and sending the creator a message.
Connecting to real data will come in a future PR.
🛠 How
Views are implemented as SwiftUI views, broken up into a few pieces, including individual flags, a project details view, a creator summary view, an address summary view, and buttons. Where possible, views used existing styling functions but did not use Prelude.
Snapshot testing is already complete and will be included in the card view PR.
👀 See
Figma
♿️ Accessibility
Should support Dynamic Type and VoiceOver, but that hasn't been confirmed
🏎 Performance
Performance will be validated when these are integrated into the pledged project list.
✅ Acceptance criteria
Feature will be more thoroughly tested against real data in a future PR after integrating. For now, all tests should pass.
⏰ TODO
Future PRs will integrate into the app UI itself and more testing can happen at that time.