[MBL-1462] Clean up OAuth flag #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Aug 6, 2024
There was a problem hiding this comment.
Note: these changes are the automatic changes xcode made when I deleted the signup screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Clean up oauth flag (defaulting to oauth behavior) and delete dead code.
I filed https://kickstarter.atlassian.net/browse/MBL-1656 as a followup so that we can make sure the
LoginViewControllerand related classes cannot and should not be cleaned up as well. (They're currently accessible from the facebook login flow, but I'm not sure if that's intentional or if it could be an oversight.)👀 See
Jira
✅ Acceptance criteria