[MBL-1608] Remove 'Update Pledge' From Manage Pledge Options Menu #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Removes 'Update Pledge' From Manage Pledge Options Menu
🤔 Why
Users will be able to manage and make changes to their pledge in the pledge redemption flow now, rendering this menu option redundant.
Taking this opportunity to clean it up.
🛠 How
When the menu options get collected in
ManagePledgeViewModel.actionSheetMenuOptionsFor(...)we can filter out the.updatePledgeoption if the feature flag is on.I added a
TODOto remind us that we can remove this option from the options struct when the feature has completed and we start cleaning up the feature flag.👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria
update pledgeoption does not appear in the manage pledge popup sheetupdate pledgeoption appears in the manage pledge popup sheet as normal