Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1616] Send backingId to CreatePaymentIntent for late pledges #2096

Merged

Conversation

scottkicks
Copy link
Contributor

📲 What

Exposes backingId in our CreateCheckout GraphQL Mutation Response in order to pass it to CreatePaymentIntent.

🤔 Why

As a backer, if my late pledge checkout errors, the payment should be reversed or the checkout rescued asynchronously (handled by Rosie (backend) if backingId is present)

🛠 How

  • Expose backingId in CreateCheckout.graphql
  • Pass newly exposed backingId to CreatePaymentIntent GraphQl call

👀 See

No visible changes

✅ Acceptance criteria

  • backingId is successfully passed along to the backend in the CreatePaymentIntent call
  • Late pledge checkout flow works as normal. (creating new and using existing payment methods specifically)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our apollo script wasn't pulling in the latest GraphAPI changes at first. Re-creating our CreateCheckout.graphql file seemed to clear whatever cache was holding that up.

It's the almost the exact same file that we currently have, other than the new object that exposes the needed backing id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto updated file based on the .graphql changes I've made. This file is updated via our bin/apollo-schema-download.sh script

@scottkicks scottkicks self-assigned this Jul 16, 2024
@scottkicks scottkicks requested review from a team and ifosli and removed request for a team July 16, 2024 17:49
@scottkicks scottkicks marked this pull request as ready for review July 16, 2024 18:05
@scottkicks scottkicks merged commit 864066d into main Jul 16, 2024
4 checks passed
@scottkicks scottkicks deleted the scott/mbl-1616/send-backingID-to-create-payyment-intent branch July 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant