Regenerate graphql-schema and update shippingRule adapter #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Regenerate graphql-schema and update the shipping rule adaptor since a recent change broke our tests (only when run on the main branch).
Note: I'm not that comfortable with graphQL changes yet so I wasn't sure if the change itself could cause problems for us in prod. I did check on our shipping rule in prod and in staging and I didn't see any errors. It looks like the change is backwards compatible in the app.
👀 See
circleCI error
✅ Acceptance criteria