MBL-1390: Add Stripe Link #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1390/add-stripe-link
branch
from
8048c8a to
faa7992
Compare
| @@ -22,15 +22,15 @@ extension STPPaymentMethod { | |||
| ]) | |||
|
|
|||
| static let sampleStringPaymentOption: (STPPaymentMethod) -> PaymentSheet.PaymentOption = { paymentMethod in | |||
| PaymentSheet.PaymentOption.saved(paymentMethod: paymentMethod) | |||
| PaymentSheet.PaymentOption.saved(paymentMethod: paymentMethod, confirmParams: nil) | |||
There was a problem hiding this comment.
Small change due to the Stripe SDK upgrade
| @@ -157,6 +157,8 @@ public final class PaymentMethodSettingsViewModel: PaymentMethodsViewModelType, | |||
| var configuration = PaymentSheet.Configuration() | |||
| configuration.merchantDisplayName = Strings.general_accessibility_kickstarter() | |||
| configuration.allowsDelayedPaymentMethods = true | |||
| configuration.defaultBillingDetails.email = AppEnvironment.current.currentUserEmail | |||
There was a problem hiding this comment.
This is how Stripe looks up the user for Stripe Link
| .retrieveSetupIntent( | ||
| withClientSecret: clientSecret, | ||
| expand: ["payment_method"] | ||
| ) { [weak self] intent, _ in |
There was a problem hiding this comment.
The callbacks for retrieveSetupIntent and for retrievePaymentIntent have different types, so they can't be shared.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1390/add-stripe-link
branch
from
faa7992 to
5d6f6ae
Compare
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
|
Converting to draft so I can add a feature flag |
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1390/add-stripe-link
branch
from
5d6f6ae to
9783d4e
Compare
scottkicks
reviewed
May 7, 2024
...tarter-iOS/Features/PledgePaymentMethods/Controller/PledgePaymentMethodsViewController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Implement Stripe Link for iOS.
🤔 Why
Stripe Link allows backers to store their card information with Stripe, and then auto-complete it when they use the Stripe payment sheet in Kickstarter. We're implementing this because it's a nicer user experience in checkout.
🛠 How
When Stripe Link returns, it gives us payment display information specific to Stripe Link - i.e. it was giving us a the Link icon and the label "Stripe Link".
To work around this, Stripe suggested we fetch the underlying payment method associated with the link, which allows us to grab the last four digits of the card and its card image. This makes Stripe Link function the way a manually added card does, and looks better in our UI.
👀 See
stripe-link-working.mp4
✅ Regression testing before merging