-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-1373] ValidateCheckout Before Completing Checkout With ApplePay #2047
Conversation
000dd7c
to
e8ba3a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments but not blocking for this pr. However, please make sure you actually test this in prod if you haven't already! With the release timeline, I'm okay with just testing that in the testflight build if that's easier and doing a rollback if we need to, but let's make sure any apple pay changes are thoroughly tested before they're released to our users.
Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also LGTM.
@ifosli Noted in regression that we should thoroughly test this in TestFlight before releasing. I also cleaned up the ApplePayParams stuff. Good call out! |
📲 What
Calls ValidateCheckout mutation after ApplePay Context completes and before CompleteOnSessionCheckout
🤔 Why
We should be validating the current late pledge checkout for ApplePay pledges like we do for Stripe pledges.
🛠 How
When the ApplePay sheet completes,
didCreatePaymentMethod
is called and we pass our ApplePayParams object back to the ViewModel to complete the checkout. This method returns aStripePayments.STPPaymentMethod
with an id (stripeId
) that we need to validate the checkout. So, we'll use that ID to call ValidateCheckout before trying to complete the checkout.👀 See
No visible changes
✅ Acceptance criteria