Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1329] Calculate total cost for each add-on #2033

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Apr 11, 2024

📲 What

When users add multiple copies of an add-on, whether in the standard pledge flow or in the late pledge flow, multiply the line item cost for that add-on by the count.

👀 See

Jira

Before 🐛 After 🦋
image image
image image

✅ Acceptance criteria

  • Line item cost matches multiplier
  • Items with just one copy are unchanged

@ifosli ifosli self-assigned this Apr 11, 2024
@ifosli ifosli changed the title [MBL-1329 Calculate total cost for each add-on [MBL-1329] Calculate total cost for each add-on Apr 11, 2024
@ifosli ifosli marked this pull request as ready for review April 11, 2024 18:12
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you double-checked ApplePay, as well? IIRC we just have one generic "rewards" line item there, we don't call out add-ons, but it'd be good to double-check.

@ifosli
Copy link
Contributor Author

ifosli commented Apr 11, 2024

LGTM. Have you double-checked ApplePay, as well? IIRC we just have one generic "rewards" line item there, we don't call out add-ons, but it'd be good to double-check.

Good idea! Just did. Yeah, apple pay has one "Reward" item that includes the cost of all rewards (including multiple of each add-on, if relevant). So that one is already good (and unchanged)!

@amy-at-kickstarter
Copy link
Contributor

LGTM. Have you double-checked ApplePay, as well? IIRC we just have one generic "rewards" line item there, we don't call out add-ons, but it'd be good to double-check.

Good idea! Just did. Yeah, apple pay has one "Reward" item that includes the cost of all rewards (including multiple of each add-on, if relevant). So that one is already good (and unchanged)!

Perfect. Maybe some day we can make ApplePay nicer, too, but might as well leave it as-it-was for now.

@ifosli ifosli merged commit c9585e6 into main Apr 11, 2024
5 checks passed
@ifosli ifosli deleted the calculateAddonSubtotal branch April 11, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants