Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1305] Don't dismiss view controller when payment fails #2007

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[MBL-1305] Don't dismiss view controller when payment fails #2007

merged 1 commit into from
Mar 28, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Mar 28, 2024 •
edited
Loading

📲 What

Instead of dismissing the checkout vc when there's an issue and the "Something went wrong, try again" banner shows, stay in the checkout vc in order to let the user actually try again.

👀 See

Jira

Before 🐛 After 🦋
Simulator Screen Recording - iPhone 15 Pro Max - 2024-03-28 at 14 24 19 Simulator Screen Recording - iPhone 15 Pro Max - 2024-03-28 at 14 21 40

✅ Acceptance criteria

  • Error banner shows but doesn't dismiss the view controller

@ifosli ifosli self-assigned this Mar 28, 2024
@ifosli ifosli marked this pull request as ready for review March 28, 2024 20:25
amy-at-kickstarter
amy-at-kickstarter approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's simple! LGTM.

@ifosli ifosli merged commit e89dccd into main Mar 28, 2024
4 checks passed
@ifosli ifosli deleted the bannerDismissesVC branch March 28, 2024 22:24
ifosli added a commit that referenced this pull request Apr 1, 2024
@ifosli
Revert "Don't pop view controller when banner dismisses (#2007)"
56d540d 
This reverts commit e89dccd.
ifosli added a commit that referenced this pull request Apr 1, 2024
@ifosli
[MBL-1305] Revert banner changes (#2011)
9cb264c 
* Revert "Don't pop view controller when banner dismisses (#2007)"

This reverts commit e89dccd.

* Add comment for clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-at-kickstarter amy-at-kickstarter amy-at-kickstarter approved these changes

Assignees

@ifosli ifosli

Labels
post-campaign-pledging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifosli @amy-at-kickstarter