Fix CircleCI error caused by GraphQL change to GraphAPI.FlaggingKind #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -810,7 +805,7 @@ public enum GraphAPI { | |||
| } | |||
| } | |||
|
|
|||
| public static var allCases: [FlaggingKind] { | |||
| public static var allCases: [NonDeprecatedFlaggingKind] { | |||
There was a problem hiding this comment.
This rename is the source of the problem.
ifosli
approved these changes
Mar 19, 2024
…hAPI.NonDeprecatedFlaggingKind
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-nondeprecatedflaggingkind-bug
branch
from
6fd9b2b to
65d72d8
Compare
| @@ -84,7 +84,7 @@ let reportSpamSubListItems = [ | |||
| ), | |||
| ReportProjectInfoListItem( | |||
| type: .child, | |||
| flaggingKind: .abuse, | |||
| flaggingKind: .guidelinesAbuse, | |||
There was a problem hiding this comment.
@scottkicks This is the one material change here - NonDeprecatedFlaggingKind does not include .abuse but it does include .guidelinesAbuse. What are these enums ultimately used for? Does it matter?
There was a problem hiding this comment.
I just tested it on staging and was able to submit a report - I tried IP and Abuse. Both look sane:
There was a problem hiding this comment.
They're used to determine the category reason why users are reporting. I think this should be fine
Generated by 🚫 Danger |
scottkicks
approved these changes
Mar 19, 2024
amy-at-kickstarter
deleted the
feat/adyer/fix-nondeprecatedflaggingkind-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
🤔 Why
Ingerid encountered this issue in a CircleCI build. Looks like we were running the Apollo update script on Circle, and it was making changes to
GraphAPI.swiftwhich broke her build. This fixes both the change to the schema, as well as makes sure that future updates to the schema will correctly cause a re-run of the Apollo build script.