MBL-1181: Update ApplePay payment total string for post campaign pledges #1978
Conversation
| @@ -9,35 +9,34 @@ extension PKPaymentRequest { | |||
| allRewardsTotal: Double, | |||
| additionalPledgeAmount: Double, | |||
| allRewardsShippingTotal: Double, | |||
| merchantIdentifier: String, | |||
| env: Environment = AppEnvironment.current | |||
There was a problem hiding this comment.
This was always the default value, so just making it explicit. I'm also checking a feature flag in here which implicitly uses AppEnvironment.current.
| ) | ||
|
|
||
| return request | ||
| } | ||
|
|
||
| private static func paymentSummaryItems( | ||
| forProject _: Project, |
There was a problem hiding this comment.
Removed unused variable
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1181
branch
from
04a19a6 to
4d7d10d
Compare
| @@ -7,8 +7,10 @@ import XCTest | |||
|
|
|||
| final class PKPaymentRequestHelpersTests: XCTestCase { | |||
| func testPaymentRequest_NoShipping() { | |||
| let project = Project.template | |||
| |> Project.lens.country .~ .us | |||
| var project = Project.template | |||
There was a problem hiding this comment.
Project is mutable, so just pulling out a little Prelude while I'm in here.
| @@ -2269,18 +2269,18 @@ Haz clic para volver a intentarlo." | |||
| ) | |||
| } | |||
| /** | |||
| "Continue with %{quantity_count} add-ons" | |||
| "Continue with %{quantity_count} add-on" | |||
There was a problem hiding this comment.
These are weird. Did something happen to muck with plurals?
There was a problem hiding this comment.
I've seen similar changes before that weirded me out. Basically, we have multiple versions of this string depending on the count. The change here is in the comment that's just for our sake; not in the actual string presented to users. I have no idea what makes the comment choose the singular vs plural version, though. I assume the change to the default value is similar (not actually going to have an effect since we're not relying on the default), but I'm not sure.
There was a problem hiding this comment.
Ooh, that makes much more sense. Cool!
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
| @@ -2269,18 +2269,18 @@ Haz clic para volver a intentarlo." | |||
| ) | |||
| } | |||
| /** | |||
| "Continue with %{quantity_count} add-ons" | |||
| "Continue with %{quantity_count} add-on" | |||
There was a problem hiding this comment.
I've seen similar changes before that weirded me out. Basically, we have multiple versions of this string depending on the count. The change here is in the comment that's just for our sake; not in the actual string presented to users. I have no idea what makes the comment choose the singular vs plural version, though. I assume the change to the default value is similar (not actually going to have an effect since we're not relying on the default), but I'm not sure.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1181
branch
from
4d7d10d to
bd77647
Compare
📲 What
Update the payment total string in ApplePay for post campaign pledges.
🤔 Why
It says "Pay Kickstarter (if funded)" by default. For PCP, it can just say "Pay Kickstarter".
👀 See