[MBL-1197] Show unavailable rewards last #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Feb 14, 2024
| @@ -44,6 +44,7 @@ final class RewardsCollectionViewControllerTests: TestCase { | |||
| func testRewards_NonBacker_LiveProject_Landscape() { | |||
| let project = Project.cosmicSurgery | |||
| |> Project.lens.state .~ .live | |||
| |> Project.lens.rewardData.rewards %~ { Array($0[1...3]) } | |||
There was a problem hiding this comment.
This just reduces the number of items so that the unavailable one shows as well, even when it's last
ifosli
commented
Feb 14, 2024
| @@ -77,24 +74,23 @@ final class RewardsCollectionViewControllerTests: TestCase { | |||
| |> Backing.lens.rewardId .~ reward.id | |||
| |> Backing.lens.shippingAmount .~ 10 | |||
| |> Backing.lens.amount .~ 700.0 | |||
| |> Backing.lens.addOns .~ [] | |||
There was a problem hiding this comment.
Opting out of add ons here ensures that this reward will be shown as unavailable when it's not selected. The default addOn has the same reward id as one of the rewards, which messes with our count for the reward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Order rewards so that unavailable ones are shown last. Note that we will need to update the
rewardIsAvailableutility method to include post campaign backings, but outside of that, this sorting will work for both.This also deletes unnecessary snapshots for the rewards tests in the first commit. The first commit looks pretty large, but it's mostly indentation changes and deleted snapshots. The second commit is the actual sorting code, with some test changes to make the tests more relevant. I recommend reviewing this one commit at a time.
👀 See
Jira and snapshot tests.
✅ Acceptance criteria