MBL-1157: Add additional tests and checks for PKCE #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
changed the title
| @@ -0,0 +1,57 @@ | |||
| import CryptoKit | |||
There was a problem hiding this comment.
Copy-pasted from the existing/previously reviewed code in PKCE.swift, just thought that file was getting a little long.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1157/pkce-upgrades
branch
from
af9bc2b to
5e76b0d
Compare
ifosli
approved these changes
Feb 7, 2024
KsApi/PKCE.swift
Outdated
|
|
||
| /// PKCE stands for Proof Key for Code Exchange. | ||
| /// The code verifier, and its associated challenge, are used to ensure that an oAuth request is valid. | ||
| /// See this documentation for more details: https://www.oauth.com/oauth2-servers/mobile-and-native-apps/authorization/ | ||
| public struct PKCE { | ||
| public static let minCodeVerifierLength = 43 | ||
| public static let maxCodeVerifierLength = 128 | ||
| public static let codeVerifierRegexPattern = "^[0-9a-zA-Z\\-._~]{43,128}$" |
There was a problem hiding this comment.
Nit: Instead of hardcoding 43 and 128 twice it might be nice to use \(minCodeVerifierLength) and same for the max.
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1157/pkce-upgrades
branch
from
0fbc16a to
0013f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
I'm adding some additional checks to the OAuth PKCE code, just to make it airtight.
🤔 Why
I want to keep iOS and Android as closely in-line as we can - this is a truly cross-platform feature, and it makes sense to keep our code equivalent. These changes are inspired by this PR on Android: https://github.com/kickstarter/android-oss/pull/1943/files
📓 Please note
You can ignore the first commit in this PR; I'm merging that separately in #1935. You can view just the relevant commit here: af9bc2b