[MBL-1152] Update Xcode version on CircleCI #1919
Conversation
ifosli
force-pushed
the
circleCIXcodeUpdate
branch
7 times, most recently
from
9df756e to
6dfb377
Compare
ifosli
force-pushed
the
circleCIXcodeUpdate
branch
from
6dfb377 to
94f101d
Compare
| @@ -211,11 +216,6 @@ internal final class DiscoveryNavigationHeaderViewController: UIViewController { | |||
| |> UILabel.lens.backgroundColor .~ .ksr_support_100 | |||
| |> UILabel.lens.isAccessibilityElement .~ false | |||
| |> UILabel.lens.textColor .~ discoveryPrimaryColor() | |||
| |> UILabel.lens.font %~~ { _, label in | |||
There was a problem hiding this comment.
Was this delete intentional? (Just because above it says initial style, unclear if it's also supposed to be able to mutate in bindViewModel).
There was a problem hiding this comment.
This is github being unhelpful - it's deleted from bindStyles and is still in bindViewModel. So the font will still be updated when the view model is updated; it just won't be reset if the traitcollection changes and bindStyles gets called again.
|
|
||
| guard supportedModels.contains(ProcessInfo().environment[modelKey] ?? "") else { | ||
| fatalError("Please only test and record screenshots on an iPhone 8 simulator running iOS 15.5") | ||
| guard deviceName == "iPhone SE (3rd generation)", iOSVersion == "17.2" else { |
There was a problem hiding this comment.
Suggestion for nice-to-have: Add a comment that these values are also in .circleci/config.yml and Makefile here, plus parallel comments in those two places. It's a bummer these values can't come from a shared file somewhere.
There was a problem hiding this comment.
That's a good idea; I'll add comments for this!
📲 What
Update Circle CI Xcode version. This also updates the test iOS version and device as well as updating ruby and our gems to be versions that align better with what's pre-installed on the virtual machine.
Note: Changes are split into two commits; one that makes the actual changes (software changes & fixing tests) and one that changes all the snapshots. Feel free to just look at the first; I went through all the snapshots and it's a tedious process. (If you do check them, I recommend github desktop & feel free to add a comment about it; I'm planning to re-check them before I submit, since I'll need to sync to main before submitting anyways).
Note: iPad padding in the login flow is noticeably different in the screenshots. Since it's also noticeably different when running the app in the simulator, I created https://kickstarter.atlassian.net/browse/MBL-1162 to look into this instead of doing that as part of this PR.
👀 See
JIRA
✅ Acceptance criteria
⏰ TODO