[MBL-1063] Use transcend privacy flow for user data requests #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
========================================
Coverage 83.74% 83.74%
========================================
Files 1229 1223 -6
Lines 112188 111811 -377
Branches 29869 29750 -119
========================================
- Hits 93955 93640 -315
+ Misses 17204 17149 -55
+ Partials 1029 1022 -7 ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger |
scottkicks
approved these changes
Jan 17, 2024
| @@ -48,10 +61,8 @@ internal final class SettingsPrivacyDeleteOrRequestCell: UITableViewCell, ValueC | |||
| ||> settingsSeparatorStyle | |||
|
|
|||
| _ = self.deleteAccountLabel | |||
| |> UILabel.lens.textColor .~ .ksr_alert | |||
| |> UILabel.lens.font .~ .ksr_body() | |||
| |> UILabel.lens.numberOfLines .~ 2 | |||
There was a problem hiding this comment.
should we move these to configureWith(... to keep all of these deleteAccountLabel styles together?
There was a problem hiding this comment.
I'd rather keep them here. I think it's often useful to treat styles that depend on input separately from styles that don't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Update "request data" and "delete account" buttons to open the new transcend privacy flow in Safari. This allows us to delete the old request flow. (The strings cannot be deleted if Android is still using them.)
Note: I moved screenshots in two different commits; one to change the images and a separate one to change the test names. This mostly led them to be correctly marked as moved, but not entirely.
👀 See
JIRA
✅ Acceptance criteria
⏰ TODO (probably in separate PR)