[MBL-1025] Update User object with server value for isBlocked #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
commented
Nov 29, 2023
| @@ -240,7 +240,7 @@ internal final class MessagesViewModelTests: TestCase { | |||
| self.scheduler.advance() | |||
|
|
|||
| self.messages.assertValueCount(1) | |||
| self.replyButtonIsEnabled.assertValues([false, false, true]) | |||
| self.replyButtonIsEnabled.assertValues([false, true, true]) | |||
There was a problem hiding this comment.
This change is because the user template now has the isBlocked explicitly set, so the isBlocked == false check causes true to be emitted instead. (I also changed isBlocked to be required to avoid weirdness like this in the future; optional bools are weird, especially when we expect them to actually exist.)
There was a problem hiding this comment.
This comment would also be good in the code!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
- Coverage 87.76% 83.70% -4.06%
==========================================
Files 861 1225 +364
Lines 77019 111585 +34566
Branches 20426 29687 +9261
==========================================
+ Hits 67592 93402 +25810
- Misses 8686 17161 +8475
- Partials 741 1022 +281 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
This makes the
isBlockedbool use the server value, for theUsermodel (and theAuthorsubset), whether it's fetched using GraphQL or v1. Tests are updated as well.Note: I also switched
isBlockedto a required instead of an optional bool, since that feels easier to use. If it's missing from the server for some reason, we default tofalse.👀 See
Jira
✅ Acceptance criteria
Author/graphQL)isBlockedcorresponds to whether or not the user is actually blocked (testsUser/v1)isBlockedto theAuthor